Fix too many logs print when listing sessions #5618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yixinglu
approved these changes
Jul 5, 2023
|
@songqing pls sign the CLA, thanks. |
done |
Sophie-Xie
pushed a commit
that referenced
this pull request
Jul 20, 2023
Sophie-Xie
added a commit
that referenced
this pull request
Jul 20, 2023
* fix traverse build path memory tracker (#5619) * Optimize the write performance when host is down (#5571) * Optimize the write performance when host is down * fix the comments --------- Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Fix too many logs print when listing sessions (#5618) * Set min_level_for_custom_filter as 0 by default to delete expired d… (#5622) Reset min_level_for_custom_filter as 0 by default to delete expired data during compaction * Revert "Revert "Change ccache to sccache"" (#5623) * Revert "Revert "Change ccache to sccache" (#5613)" This reverts commit 08a5d90. * Update pull_request.yml * Revert "Change ccache to sccache" (#5627) Revert "Revert "Revert "Change ccache to sccache"" (#5623)" This reverts commit c1b433d. * fix all path memory tracker (#5621) * fix all path memory tracker * fix error * Update pull_request.yml enable sccache debug log * Update pull_request.yml add ninja -v * Update pull_request.yml * Update pull_request.yml * Update pull_request.yml * Update pull_request.yml --------- Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Fix edge all predicate embedding when generating path (#5631) * Fix edge all predicate embedding when generate path * fmt * Enhancement/eliminate invalid filter (#5634) * Fix crash double free of expr. * Change issue id. * Elimintate invalid property filter. * support find circular (#5636) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix allpath memory tracker (#5640) fix allpath memory traker * fix_delete_validate (#5645) add test case --------- Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: Ryan <ydlu1987@gmail.com> Co-authored-by: Songqing Zhang <zhangsongqing164@163.com> Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Description:
In our cluster, there are tens of thousands of sessions established, when executing listing sessions, the metad is blocked as it will print every session to the disk, it's time costed and not very necessary.
Besides, the session id is printed twice, the first time is with VLOG(3) in the above line.
How do you solve it?
Remove the unnecessary sessions print.
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: