Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retryConnect() when using session pool #120

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

songqing
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: 119

Description:

When using SessionPool to query, there will be some connect error as the connection could be broken, then, using these connection to query will fail.

How do you solve it?

Add retryConnect() when query failed.
This implementation refers to the java client

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@songqing songqing force-pushed the add_retry_connect2 branch from ff7d26e to 22686e2 Compare August 18, 2023 10:32
@songqing
Copy link
Contributor Author

@Shylock-Hg @jievince Could you help to review?

Shylock-Hg
Shylock-Hg previously approved these changes Aug 21, 2023
@songqing
Copy link
Contributor Author

@Shylock-Hg UT failed, could you help review again?
f2

@Shylock-Hg Shylock-Hg merged commit 8c2b4dc into vesoft-inc:master Aug 21, 2023
@songqing songqing mentioned this pull request Aug 21, 2023
@wey-gu
Copy link

wey-gu commented Aug 21, 2023

Thanks a lot @songqing for the contribution, and welcome to the NebulaGraph community!

PS, given that you're a DGL contributor, I'd like to share my slow project(based on nebula-python, slow in data loading: https://github.com/wey-gu/nebula-dgl ), as I’m just curious, are you working on something that's related to both dgl and NebulaGrpah?

@QingZ11 we have a new contributor now!

@QingZ11
Copy link

QingZ11 commented Aug 21, 2023

Thanks a lot @songqing for the contribution, and welcome to the NebulaGraph community!

PS, given that you're a DGL contributor, I'd like to share my slow project(based on nebula-python, slow in data loading: https://github.com/wey-gu/nebula-dgl ), as I’m just curious, are you working on something that's related to both dgl and NebulaGrpah?

@QingZ11 we have a new contributor now!

😂 actually,songqing's first merged pr is this one #5618.

@songqing Hi, you have a contributor gift waiting to be shipped. If it's convenient for you, could you please provide your shipping information? link: https://wj.qq.com/s2/7782511/2cef/

Apologies for not reaching out to you in a timely manner. I discovered your contribution in the release note for v3.6.0 and added your GitHub avatar at the end of the release note. Once again, I apologize for not contacting you earlier.

他第一个 pr 不是这个啦,是在刚发布的 v3.6.0 里的 #5618。因为一些事情耽误了,本来想稍后联系下 songqing 的。cc @wey-gu

@songqing 你有一份待领取的贡献者礼物,如果你方便的话,可以填写下收件信息么?是这个链接哈:https://wj.qq.com/s2/7782511/2cef/ (如果这个问卷有什么需要修改的地方,也可以在问卷最后备注哈,谢谢啦)

抱歉,没能及时联系你,在 v3.6.0 的 release note 中我发现了你贡献的身影,在 release note 末加上了你的 GitHub 头像哈。再次抱歉,没能及时联系你

@songqing
Copy link
Contributor Author

Thank you~ @wey-gu, now, I do some research on Nebula and DGL both, but using them separately, I'm interested with your repo, will have a good look it later.

@songqing
Copy link
Contributor Author

Thank you @QingZ11 , I'm glad to contribute as I have learned a lot from our code, that's already a gift~

@QingZ11
Copy link

QingZ11 commented Aug 21, 2023

You have already got a personalized contributor certificate (physical) from NebulaGraph, which one is like the certificate as below.

image

BTW, we will also sent you an electronic certificate via email. The certificate numbering is currently being processed through a script, so the email is expected to be sent to your inbox around Wednesday.

@songqing
Copy link
Contributor Author

OK, thank you~

@wey-gu
Copy link

wey-gu commented Aug 21, 2023

Thank you~ @wey-gu, now, I do some research on Nebula and DGL both, but using them separately, I'm interested with your repo, will have a good look it later.

Wow, awesome! @songqing

Thank you @QingZ11 , I'm glad to contribute as I have learned a lot from our code, that's already a gift~

It's so lucky to have you in NebulaGraph Community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants