Replace unreachable with bail in finalize_css
#8694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Logs
See job summary for details |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
sokra
approved these changes
Jul 8, 2024
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Jul 12, 2024
# Turbopack * vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> ### What? Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 ### Why? To keep in sync ### How? - Closes #64890 - Closes #63104
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…#8694) ### Description @rauchg reported: ``` thread 'tokio-runtime-worker' panicked at /Users/geist/.cargo/git/checkouts/turbo-df7a549334890fa5/f5fc980/crates/turbopack-css/src/process.rs:439:22: internal error: entered unreachable code: this case should be filtered out while parsing note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` (https://vercel.slack.com/archives/C01A2M9R8RZ/p1720449958135569) A review of the code confirms that this should be unreachable under normal circumstances: > There's a check here that `FileContent::Content` exists before constructing the `ParseCssResult::Ok` that's needed to reach the line that contains the `unreachable!` assertion: https://github.com/vercel/turbo/blob/main/crates/turbopack-css/src/process.rs#L491 But there's no guarantee that the view of the world is strongly consistent across multiple `Vc`s inside most tasks. Some `Vc`s may no longer exist due to invalidation (or cache eviction once that's enabled) while this task was running. There is a guarantee that at the top-level of the application that there's strong (eventual) consistency, so we can be confident that this `bail!` won't bubble all the way up. ### Testing Instructions `cargo nextest r -p 'turbopack-*'`
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…#8694) ### Description @rauchg reported: ``` thread 'tokio-runtime-worker' panicked at /Users/geist/.cargo/git/checkouts/turbo-df7a549334890fa5/075742d/crates/turbopack-css/src/process.rs:439:22: internal error: entered unreachable code: this case should be filtered out while parsing note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` (https://vercel.slack.com/archives/C01A2M9R8RZ/p1720449958135569) A review of the code confirms that this should be unreachable under normal circumstances: > There's a check here that `FileContent::Content` exists before constructing the `ParseCssResult::Ok` that's needed to reach the line that contains the `unreachable!` assertion: https://github.com/vercel/turbo/blob/main/crates/turbopack-css/src/process.rs#L491 But there's no guarantee that the view of the world is strongly consistent across multiple `Vc`s inside most tasks. Some `Vc`s may no longer exist due to invalidation (or cache eviction once that's enabled) while this task was running. There is a guarantee that at the top-level of the application that there's strong (eventual) consistency, so we can be confident that this `bail!` won't bubble all the way up. ### Testing Instructions `cargo nextest r -p 'turbopack-*'`
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…#8694) ### Description @rauchg reported: ``` thread 'tokio-runtime-worker' panicked at /Users/geist/.cargo/git/checkouts/turbo-df7a549334890fa5/bd9ac32/crates/turbopack-css/src/process.rs:439:22: internal error: entered unreachable code: this case should be filtered out while parsing note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` (https://vercel.slack.com/archives/C01A2M9R8RZ/p1720449958135569) A review of the code confirms that this should be unreachable under normal circumstances: > There's a check here that `FileContent::Content` exists before constructing the `ParseCssResult::Ok` that's needed to reach the line that contains the `unreachable!` assertion: https://github.com/vercel/turbo/blob/main/crates/turbopack-css/src/process.rs#L491 But there's no guarantee that the view of the world is strongly consistent across multiple `Vc`s inside most tasks. Some `Vc`s may no longer exist due to invalidation (or cache eviction once that's enabled) while this task was running. There is a guarantee that at the top-level of the application that there's strong (eventual) consistency, so we can be confident that this `bail!` won't bubble all the way up. ### Testing Instructions `cargo nextest r -p 'turbopack-*'`
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…#8694) ### Description @rauchg reported: ``` thread 'tokio-runtime-worker' panicked at /Users/geist/.cargo/git/checkouts/turbo-df7a549334890fa5/3c7fb4e/crates/turbopack-css/src/process.rs:439:22: internal error: entered unreachable code: this case should be filtered out while parsing note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` (https://vercel.slack.com/archives/C01A2M9R8RZ/p1720449958135569) A review of the code confirms that this should be unreachable under normal circumstances: > There's a check here that `FileContent::Content` exists before constructing the `ParseCssResult::Ok` that's needed to reach the line that contains the `unreachable!` assertion: https://github.com/vercel/turbo/blob/main/crates/turbopack-css/src/process.rs#L491 But there's no guarantee that the view of the world is strongly consistent across multiple `Vc`s inside most tasks. Some `Vc`s may no longer exist due to invalidation (or cache eviction once that's enabled) while this task was running. There is a guarantee that at the top-level of the application that there's strong (eventual) consistency, so we can be confident that this `bail!` won't bubble all the way up. ### Testing Instructions `cargo nextest r -p 'turbopack-*'`
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
* vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 To keep in sync - Closes #64890 - Closes #63104
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
* vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 To keep in sync - Closes #64890 - Closes #63104
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 To keep in sync - Closes #64890 - Closes #63104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@rauchg reported:
(https://vercel.slack.com/archives/C01A2M9R8RZ/p1720449958135569)
A review of the code confirms that this should be unreachable under normal circumstances:
But there's no guarantee that the view of the world is strongly consistent across multiple
Vcs inside most tasks. SomeVcs may no longer exist due to invalidation (or cache eviction once that's enabled) while this task was running.There is a guarantee that at the top-level of the application that there's strong (eventual) consistency, so we can be confident that this
bail!won't bubble all the way up.Testing Instructions
cargo nextest r -p 'turbopack-*'