Add a minimum viable ResolvedValue marker trait #8662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
1903a1a to
e423571
Compare
kdy1
approved these changes
Jul 9, 2024
sokra
approved these changes
Jul 9, 2024
This trait will provide a best-effort indication that a type is safe to return from a local task function. More notes: https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff
e423571 to
2f74258
Compare
bgw
added a commit
that referenced
this pull request
Jul 9, 2024
## Description This macro allows the user to safely derive `ResolvedValue` (#8662). Most of the time, this won't be called directly, but instead as part of `#[turbo_tasks::value]` (not implemented yet). The macro works by creating a compile-time assertion for each field of a struct, enum, or union, verifying that the type of the field implements `ResolvedValue`. The assertions are designed to give relatively readable error messages, and [`trybuild`](https://github.com/dtolnay/trybuild) is used to test that. ## Example An example of this macro expansion looks like this: ``` // input code #[derive(ResolvedValue)] struct LinkedListNode<T> where T: ResolvedValue, { current: T, next: Option<Box<LinkedListNode<T>>>, } ``` ``` // generated derived impl unsafe impl<T> ::turbo_tasks::ResolvedValue for LinkedListNode<T> where T: ResolvedValue {} const _: fn() = || { struct DeriveResolvedValueAssertion<T>(T, Option<Box<LinkedListNode<T>>>) where T: ResolvedValue; impl<T> DeriveResolvedValueAssertion<T> where T: ResolvedValue, { fn assert_impl_resolved_value<ExpectedResolvedValue: ResolvedValue + ?Sized>() {} fn field_types() { Self::assert_impl_resolved_value::<T>(); Self::assert_impl_resolved_value::<Option<Box<LinkedListNode<T>>>>(); } } }; ``` ## Why? https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff ## Testing Instructions ``` cargo nextest r -p turbo-tasks-macros-tests ``` I ran this multiple times to weed out any non-determinism of the tests (I had some error order non-determinism issues). If something changes and the stderr snapshots need to be updated, you can pass in `TRYBUILD=overwrite`: ``` TRYBUILD=overwrite cargo nextest r -p turbo-tasks-macros-tests ``` I used [rust-analyzer's "expand macro" feature](https://rust-analyzer.github.io/manual.html#expand-macro-recursively) to debug some issues, and to check that the generated code is as compact as reasonably possible (we want to avoid negative impacts on compile times).
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Jul 12, 2024
# Turbopack * vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> ### What? Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 ### Why? To keep in sync ### How? - Closes #64890 - Closes #63104
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
## Description This trait will provide a best-effort indication that a type is safe to return from a local task function. This PR also makes some improvements to the `TraceRawVcs` impls that I noticed as opportunities while working on `ResolvedValue`. ## Why? https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff ## Testing Instructions Tested as part of vercel/turborepo#8678
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
## Description This macro allows the user to safely derive `ResolvedValue` (vercel/turborepo#8662). Most of the time, this won't be called directly, but instead as part of `#[turbo_tasks::value]` (not implemented yet). The macro works by creating a compile-time assertion for each field of a struct, enum, or union, verifying that the type of the field implements `ResolvedValue`. The assertions are designed to give relatively readable error messages, and [`trybuild`](https://github.com/dtolnay/trybuild) is used to test that. ## Example An example of this macro expansion looks like this: ``` // input code #[derive(ResolvedValue)] struct LinkedListNode<T> where T: ResolvedValue, { current: T, next: Option<Box<LinkedListNode<T>>>, } ``` ``` // generated derived impl unsafe impl<T> ::turbo_tasks::ResolvedValue for LinkedListNode<T> where T: ResolvedValue {} const _: fn() = || { struct DeriveResolvedValueAssertion<T>(T, Option<Box<LinkedListNode<T>>>) where T: ResolvedValue; impl<T> DeriveResolvedValueAssertion<T> where T: ResolvedValue, { fn assert_impl_resolved_value<ExpectedResolvedValue: ResolvedValue + ?Sized>() {} fn field_types() { Self::assert_impl_resolved_value::<T>(); Self::assert_impl_resolved_value::<Option<Box<LinkedListNode<T>>>>(); } } }; ``` ## Why? https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff ## Testing Instructions ``` cargo nextest r -p turbo-tasks-macros-tests ``` I ran this multiple times to weed out any non-determinism of the tests (I had some error order non-determinism issues). If something changes and the stderr snapshots need to be updated, you can pass in `TRYBUILD=overwrite`: ``` TRYBUILD=overwrite cargo nextest r -p turbo-tasks-macros-tests ``` I used [rust-analyzer's "expand macro" feature](https://rust-analyzer.github.io/manual.html#expand-macro-recursively) to debug some issues, and to check that the generated code is as compact as reasonably possible (we want to avoid negative impacts on compile times).
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
## Description This trait will provide a best-effort indication that a type is safe to return from a local task function. This PR also makes some improvements to the `TraceRawVcs` impls that I noticed as opportunities while working on `ResolvedValue`. ## Why? https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff ## Testing Instructions Tested as part of vercel/turborepo#8678
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
## Description This macro allows the user to safely derive `ResolvedValue` (vercel/turborepo#8662). Most of the time, this won't be called directly, but instead as part of `#[turbo_tasks::value]` (not implemented yet). The macro works by creating a compile-time assertion for each field of a struct, enum, or union, verifying that the type of the field implements `ResolvedValue`. The assertions are designed to give relatively readable error messages, and [`trybuild`](https://github.com/dtolnay/trybuild) is used to test that. ## Example An example of this macro expansion looks like this: ``` // input code #[derive(ResolvedValue)] struct LinkedListNode<T> where T: ResolvedValue, { current: T, next: Option<Box<LinkedListNode<T>>>, } ``` ``` // generated derived impl unsafe impl<T> ::turbo_tasks::ResolvedValue for LinkedListNode<T> where T: ResolvedValue {} const _: fn() = || { struct DeriveResolvedValueAssertion<T>(T, Option<Box<LinkedListNode<T>>>) where T: ResolvedValue; impl<T> DeriveResolvedValueAssertion<T> where T: ResolvedValue, { fn assert_impl_resolved_value<ExpectedResolvedValue: ResolvedValue + ?Sized>() {} fn field_types() { Self::assert_impl_resolved_value::<T>(); Self::assert_impl_resolved_value::<Option<Box<LinkedListNode<T>>>>(); } } }; ``` ## Why? https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff ## Testing Instructions ``` cargo nextest r -p turbo-tasks-macros-tests ``` I ran this multiple times to weed out any non-determinism of the tests (I had some error order non-determinism issues). If something changes and the stderr snapshots need to be updated, you can pass in `TRYBUILD=overwrite`: ``` TRYBUILD=overwrite cargo nextest r -p turbo-tasks-macros-tests ``` I used [rust-analyzer's "expand macro" feature](https://rust-analyzer.github.io/manual.html#expand-macro-recursively) to debug some issues, and to check that the generated code is as compact as reasonably possible (we want to avoid negative impacts on compile times).
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
## Description This trait will provide a best-effort indication that a type is safe to return from a local task function. This PR also makes some improvements to the `TraceRawVcs` impls that I noticed as opportunities while working on `ResolvedValue`. ## Why? https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff ## Testing Instructions Tested as part of vercel/turborepo#8678
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
## Description This macro allows the user to safely derive `ResolvedValue` (vercel/turborepo#8662). Most of the time, this won't be called directly, but instead as part of `#[turbo_tasks::value]` (not implemented yet). The macro works by creating a compile-time assertion for each field of a struct, enum, or union, verifying that the type of the field implements `ResolvedValue`. The assertions are designed to give relatively readable error messages, and [`trybuild`](https://github.com/dtolnay/trybuild) is used to test that. ## Example An example of this macro expansion looks like this: ``` // input code #[derive(ResolvedValue)] struct LinkedListNode<T> where T: ResolvedValue, { current: T, next: Option<Box<LinkedListNode<T>>>, } ``` ``` // generated derived impl unsafe impl<T> ::turbo_tasks::ResolvedValue for LinkedListNode<T> where T: ResolvedValue {} const _: fn() = || { struct DeriveResolvedValueAssertion<T>(T, Option<Box<LinkedListNode<T>>>) where T: ResolvedValue; impl<T> DeriveResolvedValueAssertion<T> where T: ResolvedValue, { fn assert_impl_resolved_value<ExpectedResolvedValue: ResolvedValue + ?Sized>() {} fn field_types() { Self::assert_impl_resolved_value::<T>(); Self::assert_impl_resolved_value::<Option<Box<LinkedListNode<T>>>>(); } } }; ``` ## Why? https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff ## Testing Instructions ``` cargo nextest r -p turbo-tasks-macros-tests ``` I ran this multiple times to weed out any non-determinism of the tests (I had some error order non-determinism issues). If something changes and the stderr snapshots need to be updated, you can pass in `TRYBUILD=overwrite`: ``` TRYBUILD=overwrite cargo nextest r -p turbo-tasks-macros-tests ``` I used [rust-analyzer's "expand macro" feature](https://rust-analyzer.github.io/manual.html#expand-macro-recursively) to debug some issues, and to check that the generated code is as compact as reasonably possible (we want to avoid negative impacts on compile times).
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
## Description This trait will provide a best-effort indication that a type is safe to return from a local task function. This PR also makes some improvements to the `TraceRawVcs` impls that I noticed as opportunities while working on `ResolvedValue`. ## Why? https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff ## Testing Instructions Tested as part of vercel/turborepo#8678
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
## Description This macro allows the user to safely derive `ResolvedValue` (vercel/turborepo#8662). Most of the time, this won't be called directly, but instead as part of `#[turbo_tasks::value]` (not implemented yet). The macro works by creating a compile-time assertion for each field of a struct, enum, or union, verifying that the type of the field implements `ResolvedValue`. The assertions are designed to give relatively readable error messages, and [`trybuild`](https://github.com/dtolnay/trybuild) is used to test that. ## Example An example of this macro expansion looks like this: ``` // input code #[derive(ResolvedValue)] struct LinkedListNode<T> where T: ResolvedValue, { current: T, next: Option<Box<LinkedListNode<T>>>, } ``` ``` // generated derived impl unsafe impl<T> ::turbo_tasks::ResolvedValue for LinkedListNode<T> where T: ResolvedValue {} const _: fn() = || { struct DeriveResolvedValueAssertion<T>(T, Option<Box<LinkedListNode<T>>>) where T: ResolvedValue; impl<T> DeriveResolvedValueAssertion<T> where T: ResolvedValue, { fn assert_impl_resolved_value<ExpectedResolvedValue: ResolvedValue + ?Sized>() {} fn field_types() { Self::assert_impl_resolved_value::<T>(); Self::assert_impl_resolved_value::<Option<Box<LinkedListNode<T>>>>(); } } }; ``` ## Why? https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff ## Testing Instructions ``` cargo nextest r -p turbo-tasks-macros-tests ``` I ran this multiple times to weed out any non-determinism of the tests (I had some error order non-determinism issues). If something changes and the stderr snapshots need to be updated, you can pass in `TRYBUILD=overwrite`: ``` TRYBUILD=overwrite cargo nextest r -p turbo-tasks-macros-tests ``` I used [rust-analyzer's "expand macro" feature](https://rust-analyzer.github.io/manual.html#expand-macro-recursively) to debug some issues, and to check that the generated code is as compact as reasonably possible (we want to avoid negative impacts on compile times).
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
* vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 To keep in sync - Closes #64890 - Closes #63104
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
* vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 To keep in sync - Closes #64890 - Closes #63104
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8686 <!-- Tobias Koppers - improve performance of the graph aggregation --> * vercel/turborepo#8694 <!-- Benjamin Woodruff - Replace `unreachable` with `bail` in `finalize_css` --> * vercel/turborepo#8661 <!-- Benjamin Woodruff - Create a minimum viable `ResolvedVc` type --> * vercel/turborepo#8662 <!-- Benjamin Woodruff - Add a minimum viable ResolvedValue marker trait --> * vercel/turborepo#8678 <!-- Benjamin Woodruff - Add derive macro for ResolvedValue --> * vercel/turborepo#8715 <!-- Benjamin Woodruff - Switch RcStr from std::sync::Arc to triomphe::Arc --> * vercel/turborepo#8699 <!-- Donny/강동윤 - perf: Merge multiple `EsmBinding` --> * vercel/turborepo#8720 <!-- Benjamin Woodruff - Add support for `#[turbo_tasks::value(resolved)]` and `#[turbo_tasks::value_trait(resolved)]` --> * vercel/turborepo#8706 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.96.9` --> Update SWC crates to swc-project/swc@226617e and swc-project/plugins@b7658c3 To keep in sync - Closes #64890 - Closes #63104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This trait will provide a best-effort indication that a type is safe to return from a local task function.
This PR also makes some improvements to the
TraceRawVcsimpls that I noticed as opportunities while working onResolvedValue.Why?
https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff
Testing Instructions
Tested as part of #8678