generate correct async module handling for side effects optimization #7720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
kdy1
reviewed
Mar 13, 2024
crates/turbopack-ecmascript/src/side_effect_optimization/locals/chunk_item.rs
Outdated
Show resolved
Hide resolved
kdy1
approved these changes
Mar 13, 2024
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2024
# Turbopack * vercel/turborepo#7719 <!-- Tobias Koppers - accept css files outside of the project as virtual assets --> * vercel/turborepo#7661 <!-- Tobias Koppers - more efficient node.js process startup --> * vercel/turborepo#7720 <!-- Tobias Koppers - generate correct async module handling for side effects optimization --> * vercel/turborepo#7718 <!-- Donny/강동윤 - fix(turbopack): Fix CSS Modules class name for lightningcss mode --> ### What? Update tests to make CSS Modules of `lightningcss` work with CSS grids. ### Why? `lightningcss` enforces the class name to end with `[local]`. See: https://lightningcss.dev/css-modules.html#css-grid ### How? Closes PACK-2731
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…ercel/turborepo#7720) ### Description Async module handling was missing for side effects optimized modules ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2733
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…ercel/turborepo#7720) ### Description Async module handling was missing for side effects optimized modules ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2733
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…ercel/turborepo#7720) ### Description Async module handling was missing for side effects optimized modules ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2733
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…ercel/turborepo#7720) ### Description Async module handling was missing for side effects optimized modules ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Async module handling was missing for side effects optimized modules
Testing Instructions
Closes PACK-2733