Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept css files outside of the project as virtual assets #7719

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 13, 2024

Description

This can actually happen e. g. with next/font, which creates virtual css files that are not inside of the project directory

Testing Instructions

Closes PACK-2732

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 7:36am
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 7:36am
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 7:36am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 7:36am
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 7:36am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 7:36am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 7:36am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 7:36am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 7:36am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 7:36am

Copy link
Contributor

github-actions bot commented Mar 13, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Mar 13, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Contributor

✅ This change can build next-swc

@sokra sokra disabled auto-merge March 13, 2024 07:38
@sokra sokra merged commit 1c46667 into main Mar 13, 2024
45 of 47 checks passed
@sokra sokra deleted the sokra/accept-virtual-assets-in-postcss branch March 13, 2024 07:38
kdy1 added a commit to vercel/next.js that referenced this pull request Mar 13, 2024
# Turbopack

* vercel/turborepo#7719 <!-- Tobias Koppers - accept
css files outside of the project as virtual assets -->
* vercel/turborepo#7661 <!-- Tobias Koppers - more
efficient node.js process startup -->
* vercel/turborepo#7720 <!-- Tobias Koppers -
generate correct async module handling for side effects optimization -->
* vercel/turborepo#7718 <!-- Donny/강동윤 -
fix(turbopack): Fix CSS Modules class name for lightningcss mode -->

### What?

Update tests to make CSS Modules of `lightningcss` work with CSS grids.

### Why?

`lightningcss` enforces the class name to end with `[local]`.

See: https://lightningcss.dev/css-modules.html#css-grid


### How?

Closes PACK-2731
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…borepo#7719)

### Description

This can actually happen e. g. with next/font, which creates virtual css
files that are not inside of the project directory

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2732
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…borepo#7719)

### Description

This can actually happen e. g. with next/font, which creates virtual css
files that are not inside of the project directory

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2732
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…borepo#7719)

### Description

This can actually happen e. g. with next/font, which creates virtual css
files that are not inside of the project directory

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2732
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…borepo#7719)

### Description

This can actually happen e. g. with next/font, which creates virtual css
files that are not inside of the project directory

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants