Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partially migrate to webpack 5 types #30189

Merged
merged 7 commits into from
Oct 24, 2021
Merged

partially migrate to webpack 5 types #30189

merged 7 commits into from
Oct 24, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 22, 2021

fix type declarations to avoid import from webpack/webpack4/webpack5 in type declarations

fix type declarations to avoid import from webpack/webpack4/webpack5 in type declarations
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@sokra sokra marked this pull request as ready for review October 24, 2021 19:43
@@ -30,6 +30,12 @@
},
"peerDependencies": {
"react": "^17.0.2",
"react-dom": "^17.0.2"
"react-dom": "^17.0.2",
"webpack": "^4 || ^5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still planning to support webpack 4 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used only in the typings, so it doesn't really matter...

@ijjk
Copy link
Member

ijjk commented Oct 24, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js type/webpack-reference Change
buildDuration 17.3s 17.5s ⚠️ +208ms
buildDurationCached 3.5s 3.6s ⚠️ +125ms
nodeModulesSize 196 MB 196 MB ⚠️ +600 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js type/webpack-reference Change
/ failed reqs 0 0
/ total time (seconds) 2.893 2.851 -0.04
/ avg req/sec 864.09 876.95 +12.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.373 1.4 ⚠️ +0.03
/error-in-render avg req/sec 1821.38 1785.8 ⚠️ -35.58
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js type/webpack-reference Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.7 kB 27.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js type/webpack-reference Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js type/webpack-reference Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
9a34b27eb3f9..27d.css gzip 125 B 125 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js type/webpack-reference Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js type/webpack-reference Change
index.html gzip 535 B 535 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js type/webpack-reference Change
buildDuration 14.6s 14.7s ⚠️ +75ms
buildDurationCached 3.5s 3.6s ⚠️ +20ms
nodeModulesSize 196 MB 196 MB ⚠️ +600 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js type/webpack-reference Change
/ failed reqs 0 0
/ total time (seconds) 2.892 2.903 ⚠️ +0.01
/ avg req/sec 864.47 861.11 ⚠️ -3.36
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.423 1.367 -0.06
/error-in-render avg req/sec 1756.37 1829.15 +72.78
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js type/webpack-reference Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js type/webpack-reference Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js type/webpack-reference Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
9a34b27eb3f9..27d.css gzip 125 B 125 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js type/webpack-reference Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js type/webpack-reference Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: f49bdf1

@ijjk
Copy link
Member

ijjk commented Oct 24, 2021

Failing test suites

Commit: f49bdf1

test/development/basic/hmr.test.ts

  • basic HMR > Error Recovery > should recover after an error reported via SSR
Expand output

● basic HMR › Error Recovery › should recover after an error reported via SSR

TIMED OUT: /an-expected-error-in-gip/

null

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:502:17)

@sokra sokra merged commit d2f96f5 into canary Oct 24, 2021
@sokra sokra deleted the type/webpack-reference branch October 24, 2021 21:04
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants