Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make import trace consistent between runtime and build #30175

Merged
merged 5 commits into from
Oct 22, 2021
Merged

make import trace consistent between runtime and build #30175

merged 5 commits into from
Oct 22, 2021
+26 −28

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 22, 2021

No description provided.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 22, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@sokra sokra marked this pull request as ready for review October 22, 2021 18:02
ijjk
ijjk reviewed Oct 22, 2021
View reviewed changes
packages/next/build/webpack/plugins/wellknown-errors-plugin/webpackModuleError.ts
import { getBabelError } from './parseBabel'
import { getCssError } from './parseCss'
import { getScssError } from './parseScss'
import { getNotFoundError } from './parseNotFoundError'
import { SimpleWebpackError } from './simpleWebpackError'
import isError from '../../../../lib/is-error'
import type webpack5 from 'webpack5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to avoid importing from webpack5 directly? Seems to be causing issues in some cases #30167

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting issue... Actually we are import webpack5 in multiple places...
To avoid that we could merge all types into next/dist/compiled/webpack/webpack and only import that one...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I think we can do that in a follow-up PR so this one looks good to land.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#30189

@ijjk
Copy link
Member

ijjk commented Oct 22, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js ci/stability Change
buildDuration 15.5s 15.5s ⚠️ +26ms
buildDurationCached 3.3s 3.4s ⚠️ +19ms
nodeModulesSize 196 MB 196 MB -365 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js ci/stability Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.803 3.884 ⚠️ +0.08
/ avg req/sec 657.34 643.63 ⚠️ -13.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.023 2.036 ⚠️ +0.01
/error-in-render avg req/sec 1235.91 1227.65 ⚠️ -8.26
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js ci/stability Change
651.cd440d20..0b23.js gzip 2.96 kB 2.96 kB ✓
831.695e33f6..205f.js gzip 179 B 179 B ✓
framework-89..a097.js gzip 42.2 kB 42.2 kB ✓
main-167207f..648c.js gzip 26.1 kB 26.1 kB ✓
webpack-f09b..493e.js gzip 1.47 kB 1.47 kB ✓
Overall change 72.9 kB 72.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js ci/stability Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js ci/stability Change
_app-9fb8765..c13d.js gzip 979 B 979 B ✓
_error-d828d..2954.js gzip 3.06 kB 3.06 kB ✓
amp-5388d1f5..4ce9.js gzip 551 B 551 B ✓
css-10424225..367a.js gzip 329 B 329 B ✓
dynamic-9821..3cd4.js gzip 2.67 kB 2.67 kB ✓
head-1df323b..d261.js gzip 2.32 kB 2.32 kB ✓
hooks-ab0016..b093.js gzip 917 B 917 B ✓
image-a30860..3c27.js gzip 5.85 kB 5.85 kB ✓
index-95c8cb..6970.js gzip 260 B 260 B ✓
link-05c99e7..35ec.js gzip 1.66 kB 1.66 kB ✓
routerDirect..6659.js gzip 319 B 319 B ✓
script-d94ba..ed05.js gzip 386 B 386 B ✓
withRouter-7..8b2e.js gzip 317 B 317 B ✓
9a34b27eb3f9..27d.css gzip 125 B 125 B ✓
Overall change 19.7 kB 19.7 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js ci/stability Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js ci/stability Change
index.html gzip 537 B 537 B ✓
link.html gzip 548 B 548 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js ci/stability Change
buildDuration 7.3s 7.4s ⚠️ +86ms
buildDurationCached 3.4s 3.5s ⚠️ +98ms
nodeModulesSize 196 MB 196 MB -365 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js ci/stability Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.658 3.751 ⚠️ +0.09
/ avg req/sec 683.53 666.5 ⚠️ -17.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.895 1.964 ⚠️ +0.07
/error-in-render avg req/sec 1319.04 1273.16 ⚠️ -45.88
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js ci/stability Change
450.fd3ad245..022b.js gzip 179 B 179 B ✓
675-228d3e2f..0c27.js gzip 13.8 kB 13.8 kB ✓
framework-13..70b0.js gzip 50.8 kB 50.8 kB ✓
main-d78cd7f..aaf4.js gzip 36.5 kB 36.5 kB ✓
webpack-a7f2..2650.js gzip 1.63 kB 1.63 kB ✓
Overall change 103 kB 103 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js ci/stability Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js ci/stability Change
_app-ae91bc3..d985.js gzip 1.33 kB 1.33 kB ✓
_error-273ac..9ef0.js gzip 180 B 180 B ✓
amp-5f9a7694..99ce.js gzip 315 B 315 B ✓
css-3a1b2477..df1e.js gzip 330 B 330 B ✓
dynamic-e04a..a1b5.js gzip 2.79 kB 2.79 kB ✓
head-7f600d0..daa3.js gzip 356 B 356 B ✓
hooks-bd8c02..0730.js gzip 638 B 638 B ✓
image-6365b7..7506.js gzip 536 B 536 B ✓
index-80be94..e89f.js gzip 262 B 262 B ✓
link-4ee1ea7..8745.js gzip 2.22 kB 2.22 kB ✓
routerDirect..c4aa.js gzip 325 B 325 B ✓
script-67da0..49e6.js gzip 390 B 390 B ✓
withRouter-2..2409.js gzip 322 B 322 B ✓
9a34b27eb3f9..27d.css gzip 125 B 125 B ✓
Overall change 10.1 kB 10.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js ci/stability Change
_buildManifest.js gzip 477 B 477 B ✓
Overall change 477 B 477 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js ci/stability Change
index.html gzip 535 B 535 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 73d98c3

@kodiakhq kodiakhq bot merged commit ab50a4e into canary Oct 22, 2021
@kodiakhq kodiakhq bot deleted the ci/stability branch October 22, 2021 19:32
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @ijjk @styfle