Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix PnP e2e tests using Webpack 5 #24216

Merged
merged 1 commit into from
Apr 19, 2021
Merged

ci: fix PnP e2e tests using Webpack 5 #24216

merged 1 commit into from
Apr 19, 2021

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Apr 19, 2021 •
edited
Loading

Fixes the e2e PnP tests by updating enhanced-resolve to get the fix in webpack/enhanced-resolve#289, the tests started failing in #23810

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Apr 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
buildDuration 14.5s 14.5s -45ms
buildDurationCached 4.6s 4.4s -215ms
nodeModulesSize 46.3 MB 46.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.683 2.732 ⚠️ +0.05
/ avg req/sec 931.74 915.17 ⚠️ -16.57
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.513 1.606 ⚠️ +0.09
/error-in-render avg req/sec 1652.74 1556.92 ⚠️ -95.82
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
index.html gzip 609 B 609 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
buildDuration 18.4s 18.5s ⚠️ +73ms
buildDurationCached 6.4s 6.4s -17ms
nodeModulesSize 46.3 MB 46.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ⚠️ +2 B
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ⚠️ +2 B
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.15 MB 7.15 MB ⚠️ +4 B
Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
buildDuration 12.1s 12.3s ⚠️ +234ms
buildDurationCached 5.1s 4.8s -349ms
nodeModulesSize 46.3 MB 46.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.651 2.686 ⚠️ +0.04
/ avg req/sec 942.93 930.81 ⚠️ -12.12
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.586 1.483 -0.1
/error-in-render avg req/sec 1576.37 1685.99 +109.62
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.16 kB 7.16 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 41882a4

@ijjk
Copy link
Member

ijjk commented Apr 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
buildDuration 13.8s 13.7s -108ms
buildDurationCached 4.2s 4.2s -25ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +298 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.434 2.437 0
/ avg req/sec 1027.1 1026.04 ⚠️ -1.06
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.288 1.297 ⚠️ +0.01
/error-in-render avg req/sec 1940.4 1927.78 ⚠️ -12.62
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
index.html gzip 609 B 609 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
buildDuration 17.4s 17.6s ⚠️ +225ms
buildDurationCached 6.2s 6.3s ⚠️ +93ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +298 B
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.08 kB 7.08 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ⚠️ +4 B
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.15 MB 7.15 MB ⚠️ +4 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
buildDuration 11.8s 11.8s ⚠️ +80ms
buildDurationCached 4.7s 4.8s ⚠️ +45ms
nodeModulesSize 46.3 MB 46.3 MB ⚠️ +298 B
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.421 2.417 0
/ avg req/sec 1032.52 1034.38 +1.86
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.25 1.245 0
/error-in-render avg req/sec 1999.42 2008.29 +8.87
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.16 kB 7.16 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
hooks-HASH.js gzip 888 B 888 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/pnp-e2e Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 4ec289a

timneutkens
timneutkens approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit d24a0c1 into vercel:canary Apr 19, 2021
@merceyz merceyz deleted the merceyz/pnp-e2e branch April 19, 2021 16:06
@merceyz merceyz mentioned this pull request Apr 19, 2021
Merged
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@merceyz @SokratisVidros
ci: fix PnP e2e tests using Webpack 5 (vercel#24216)
a737264 
Fixes the e2e PnP tests by updating `enhanced-resolve` to get the fix in webpack/enhanced-resolve#289, the tests started failing in vercel#23810

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@merceyz merceyz mentioned this pull request Apr 22, 2021
Closed
8 tasks
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merceyz @ijjk @timneutkens