-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for typescript loader #2250
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 |
You can use my boilerplate before this PR is merged. |
Is this going anywhere? Would be really awesome to have TS support a bit more "baked-in", and it seems like this goes a long way towards that |
Going to research this in #2391 thanks for the inspiration ❤️ |
Closed
robdmoore
added a commit
to dddwa/dddperth-website
that referenced
this pull request
Feb 28, 2018
…ary/examples/with-typescript Waiting for vercel/next.js#2250 and vercel/next.js#2699 and vercel/next.js#2391 to land to add proper support via Webpack
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to allow using typescript through a custom config.
Typescript pages are loaded directly from the pages folder without pre compiling sources using ts-loader then it piggybacks on the default webpack loaders to output valid js.
Can someone provide feedback on how to better implement this?