Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on Linux default to "showHamburgerMenu": true #2666

Merged
merged 1 commit into from
Mar 17, 2018
Merged

on Linux default to "showHamburgerMenu": true #2666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/config/config-default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,8 @@ module.exports = {
// custom CSS to embed in the terminal window
termCSS: '',

// set to `true` (without backticks and without quotes) if you're using a
// Linux setup that doesn't show native menus
// default: `false` on Linux, `true` on Windows, ignored on macOS
// if you're using a Linux setup which show native menus, set to false
// default: `true` on Linux, `true` on Windows, ignored on macOS
showHamburgerMenu: '',

// set to `false` (without backticks and without quotes) if you want to hide the minimize, maximize and close buttons
Expand Down
2 changes: 1 addition & 1 deletion lib/components/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export default class Header extends PureComponent {
const {showHamburgerMenu, showWindowControls} = this.props;

const defaults = {
hambMenu: process.platform === 'win32', // show by default on windows
hambMenu: !this.props.isMac, // show by default on windows and linux
winCtrls: !this.props.isMac // show by default on Windows and Linux
};

Expand Down