on Linux default to "showHamburgerMenu": true

[jcrben]

I believe this is ready to merge, but I didn't go through and run from source to check. This is partly to open a discussion and get a better understanding of why this default was selected. Another possible resolution to the underlying issue is figuring out how to get the title menu bar to work consistently on Linux.

If a minimal flow is felt to be super important, then I recommend an in-app onboarding wizard to help users understand how to access their menu bar. But until that's built, a menu should be visible by default.

From the code comment // show by default on Windows and Linux, it appears that the author expected the window menu to appear on Linux, but this isn't actually happening. Therefore I think it would be better to default to showing the hamburger menu and letting experienced users configure it away.

When I loaded up hyper on Linux, I couldn't access the menu at all. I saw this - and I didn't have an overall menu bar like macOS on Ubuntu 17.10 running KDE Plasma thru Virtualbox:

Issues from this that I found quickly:

• Hamburger menu not visible on Linux #1266 (most commonly-cited)
• Missing hamburger menu Fedora 25 #1118
• No Menu on Debian (Gnome Shell) #1168
• Hyper does not show menus on Fedora 25 with Gnome #1373
• Menu only show when maximized on Ubuntu #1234
• No menu bar in fedora? #1195

Blame points to #946 which does not discuss this issue.

There is a mention of the frameless thing which I haven't messed around with (#795 - maybe that could help with #1683 and showing the title menu bar).

[chabou]

I am agreed. We need to enable it by default on Linux.
Thank you so much for your PR.

Do you mind to modify comment in default config file too?
https://github.com/zeit/hyper/blob/76beaa32f5f3285bc8f7083fff8cd722ba97f60a/app/config/config-default.js#L56

[chabou]

Config comment should be updated.

[jcrben]

Updated. I think this gets into the whole Client Side Decorations going on in the Linux world. GNOME has an initiative to focus on client-side window decorations (https://wiki.gnome.org/Initiatives/CSD).

Using the hamburgerMenu aligns hyper with GNOME, but also I'm running KDE on Ubuntu 17.10 and it also isn't showing native menus, so it seems to cover modern KDE too (granted, I'm building Ubuntu from a server ISO https://gitlab.com/jcrben-play-learn/packer-desktop). I think that frameless param mentioned above has something to do with no native menus.