Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python : Client API for retrieving internal statistics #2707

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

BoazBD
Copy link
Collaborator

@BoazBD BoazBD commented Nov 18, 2024

Implements the Python part for this issue:
#2376

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: BoazBD <boazbd@amazon.com>
@BoazBD BoazBD marked this pull request as ready for review November 18, 2024 12:27
@BoazBD BoazBD requested a review from a team as a code owner November 18, 2024 12:27
@BoazBD BoazBD requested a review from eifrah-aws November 18, 2024 12:28
python/src/lib.rs Outdated Show resolved Hide resolved
python/src/lib.rs Outdated Show resolved Hide resolved
Signed-off-by: BoazBD <boazbd@amazon.com>
@Yury-Fridlyand Yury-Fridlyand added the python Python wrapper label Nov 18, 2024
@BoazBD BoazBD merged commit 86fa0d4 into release-1.2 Nov 19, 2024
20 of 21 checks passed
@BoazBD BoazBD deleted the python/add-get-statistics-support branch November 19, 2024 10:08
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Nov 19, 2024
* add get statistics support to python wrapper

Signed-off-by: BoazBD <boazbd@amazon.com>

* fmt rust

Signed-off-by: BoazBD <boazbd@amazon.com>

* fix deprecated funcs

Signed-off-by: BoazBD <boazbd@amazon.com>

* fmt again

Signed-off-by: BoazBD <boazbd@amazon.com>

* add to changelog

Signed-off-by: BoazBD <boazbd@amazon.com>

* refactor imports

Signed-off-by: BoazBD <boazbd@amazon.com>

---------

Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Nov 19, 2024
* add get statistics support to python wrapper

Signed-off-by: BoazBD <boazbd@amazon.com>

* fmt rust

Signed-off-by: BoazBD <boazbd@amazon.com>

* fix deprecated funcs

Signed-off-by: BoazBD <boazbd@amazon.com>

* fmt again

Signed-off-by: BoazBD <boazbd@amazon.com>

* add to changelog

Signed-off-by: BoazBD <boazbd@amazon.com>

* refactor imports

Signed-off-by: BoazBD <boazbd@amazon.com>

---------

Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
avifenesh added a commit that referenced this pull request Nov 19, 2024
Python : Client API for retrieving internal statistics (#2707)

* add get statistics support to python wrapper



* fmt rust



* fix deprecated funcs



* fmt again



* add to changelog



* refactor imports



---------

Signed-off-by: BoazBD <boazbd@amazon.com>
Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Co-authored-by: BoazBD <50696333+BoazBD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants