-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose active Redis connection count #2376
Comments
This information is available using |
Oh, perhaps I wasn't clear. I want info logged from the behaviour of this specific client – not |
Thanks, I agree that we should improve and expose the clients metrics. I agree that it is more than just connected clients, can be latency, errors, internal reconnects attempts... |
Marking a candidate for 1.2 |
@nakedible-p note that for this solution, I have chosen to take the path of providing telemetry for the entire process. i.e. if you have 2 clients opened, it will report all opened connections for both of them (the sum of it). In addition, it will also report how many active clients there are |
@asafpamzn i dont see how it makes into 1.2 - lets discuss Binding status: |
Marking this as completed. We now have |
Describe the feature
It would be nice to be able to query the client about at least some status and statistics information to be logged. The first piece of information that's interesting is the currently active connection count.
Use Case
We want to log the currently active connection count towards Redis, so we can make a metric of it and track it. It's also not obvious what that is without getting the real data as the cluster layout affects it. It's also a resource tracking issue possibly. There's a ton of other values that could be exposed as well.
Proposed Solution
Add a simple
get_active_connection_count()
call. Alternatively, something likeget_statistics()
which would return an object which has this value and a bunch of other values. Something like this is a good example of a full blown solution: https://docs.rs/tokio/latest/tokio/runtime/struct.RuntimeMetrics.htmlOther Information
No response
Acknowledgements
Client version used
1.1.0
Environment details (OS name and version, etc.)
irrelevant
The text was updated successfully, but these errors were encountered: