Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Added XDEL command #2064

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Aug 1, 2024

@GumpacG GumpacG requested a review from a team as a code owner August 1, 2024 00:14
@GumpacG GumpacG force-pushed the node/integ_guiang_xdel_valkey-61 branch from 3a8cd32 to 5254113 Compare August 1, 2024 00:15
@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label Aug 1, 2024
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Show resolved Hide resolved
@GumpacG GumpacG force-pushed the node/integ_guiang_xdel_valkey-61 branch from 2947fc5 to c8b29bb Compare August 1, 2024 17:53
for (let i = 0; i < 10000; i++) {
expectedNumberMapArray.push(i.toString());
expectedNumberMapArray.push(i.toString());
for (let i = 0; i < 50000; i++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be its own PR ;)
I'll let it slide this time

GumpacG added 5 commits August 1, 2024 13:58
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG GumpacG force-pushed the node/integ_guiang_xdel_valkey-61 branch from e9a6bd0 to 8d898d5 Compare August 1, 2024 20:59
@GumpacG GumpacG merged commit 5ae81cc into valkey-io:main Aug 1, 2024
8 checks passed
@GumpacG GumpacG deleted the node/integ_guiang_xdel_valkey-61 branch August 1, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants