Addressed PR comments

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
valkey-io · Aug 1, 2024 · c8b29bb · c8b29bb
1 parent 03b7f49
commit c8b29bb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/node/src/BaseClient.ts b/node/src/BaseClient.ts
@@ -3505,7 +3505,7 @@ export class BaseClient {
      * // Output is 2 since the stream marked 2 entries as deleted.
      * ```
      */
-    public xdel(key: string, ids: string[]): Promise<string> {
+    public xdel(key: string, ids: string[]): Promise<number> {
         return this.createWritePromise(createXDel(key, ids));
     }
 

diff --git a/node/src/Transaction.ts b/node/src/Transaction.ts
@@ -1984,6 +1984,7 @@ export class BaseTransaction<T extends BaseTransaction<T>> {
      *
      * @param key - The key of the stream.
      * @param values - field-value pairs to be added to the entry.
+     * @param options - (Optional) Stream add options.
      *
      * Command Response - The id of the added entry, or `null` if `options.makeStream` is set to `false` and no stream with the matching `key` exists.
      */