Node: add GEOSEARCH
#2007
Node: add GEOSEARCH
#2007
Conversation
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…-GEOSEARCH-valkey-90 Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…H-valkey-90 Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
| * | ||
| * @param key - The key of the sorted set. | ||
| * @param searchFrom - The query's center point options, could be one of: | ||
| * |
There was a problem hiding this comment.
Just curious...
Are we going to have extra line for each sub-item?
There was a problem hiding this comment.
It is needed for line breaks in the list. Withot that, all bullet points are rendered in one messy line without a list formatting.
Co-authored-by: Yi-Pin Chen <yi-pin.chen@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
| ): command_request.Command { | ||
| let args: string[] = [key]; | ||
|
|
||
| if ("position" in searchFrom) { |
There was a problem hiding this comment.
Can we have a different check here? Checking for string seems incorrect here.
There was a problem hiding this comment.
It checks for the named property/field in the variable. typeof/instanceof doesn't work there unfortunately. Do you have a better idea how to do a runtime type check?
There was a problem hiding this comment.
this is the standard way to do it
…H-valkey-90 Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
| ): command_request.Command { | ||
| let args: string[] = [key]; | ||
|
|
||
| if ("position" in searchFrom) { |
There was a problem hiding this comment.
this is the standard way to do it
…H-valkey-90 Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
|
deleted |
Refs: #1482 and #1685
And update docs for java and python commands.
Includes some changes from #2005