-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Add Command GeoSearch & GeoSearchStore #1685
Merged
tjzhang-BQ
merged 3 commits into
valkey-io:main
from
Bit-Quill:java/integ_tjz_geosearch
Jun 29, 2024
Merged
Java: Add Command GeoSearch & GeoSearchStore #1685
tjzhang-BQ
merged 3 commits into
valkey-io:main
from
Bit-Quill:java/integ_tjz_geosearch
Jun 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulazariy
previously requested changes
Jun 27, 2024
Yury-Fridlyand
dismissed
yulazariy’s stale review
June 28, 2024 03:01
Converting to GlideString
is out of scope of that PR
Elen-Ghulam
approved these changes
Jun 28, 2024
* Java: Add Command GeoSearch & GeoSearchStore ---------
tjzhang-BQ
force-pushed
the
java/integ_tjz_geosearch
branch
from
June 28, 2024 18:57
0f8d199
to
94de265
Compare
yipin-chen
reviewed
Jun 28, 2024
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Show resolved
Hide resolved
yipin-chen
reviewed
Jun 28, 2024
java/client/src/main/java/glide/api/models/commands/geospatial/GeoSearchOptions.java
Outdated
Show resolved
Hide resolved
yipin-chen
approved these changes
Jun 28, 2024
jduo
reviewed
Jun 29, 2024
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
jduo
reviewed
Jun 29, 2024
java/client/src/main/java/glide/api/models/commands/geospatial/GeoSearchOptions.java
Outdated
Show resolved
Hide resolved
jduo
reviewed
Jun 29, 2024
java/client/src/main/java/glide/api/models/commands/geospatial/GeoSearchOptions.java
Show resolved
Hide resolved
jduo
reviewed
Jun 29, 2024
java/client/src/main/java/glide/api/models/commands/geospatial/GeoSearchStoreOptions.java
Outdated
Show resolved
Hide resolved
jduo
approved these changes
Jun 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much other than fixing up Redis references.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.