Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add GEOPOS command. #1991

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

ref #1394

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label Jul 20, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner July 20, 2024 02:49
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

node/src/Transaction.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand merged commit 52a7ed6 into valkey-io:main Jul 23, 2024
8 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/yuryf_GEOPOS branch July 23, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants