Java: Add command GEOPOS
#1394
Merged
Java: Add command GEOPOS
#1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
approved these changes
May 8, 2024
Comment on lines
+73
to
+74
| * // When added via GEOADD, the geospatial coordinates are converted into a 52 bit geohash, so the coordinates | ||
| * // returned might not be exactly the same as the input values |
There was a problem hiding this comment.
I think we need to move this comment to geoadd docs.
There was a problem hiding this comment.
I think it's fine where it is. This is an implementation detail, and it's most apparent in the test. Users should look up the implementation details by visiting ValKey to know more.
acarbonetto
approved these changes
May 9, 2024
Comment on lines
+73
to
+74
| * // When added via GEOADD, the geospatial coordinates are converted into a 52 bit geohash, so the coordinates | ||
| * // returned might not be exactly the same as the input values |
There was a problem hiding this comment.
I think it's fine where it is. This is an implementation detail, and it's most apparent in the test. Users should look up the implementation details by visiting ValKey to know more.
Elen-Ghulam
approved these changes
May 9, 2024
avifenesh
pushed a commit
that referenced
this pull request
May 14, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Java: Add command Geopos (#267)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.