-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter number of clients according to tasks. #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There' no need to create more clients than the number of concurrent tasks, since the extra clients won't be used.
barshaul
approved these changes
Mar 20, 2023
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Apr 4, 2024
* Java: Add XADD command (Stream commands) (#155) Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: SanHalacogluImproving <144171266+SanHalacogluImproving@users.noreply.github.com>
shohamazon
pushed a commit
to adanWattad/glide-for-redis
that referenced
this pull request
Apr 9, 2024
* Java: Add XADD command (Stream commands) (valkey-io#155) Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: SanHalacogluImproving <144171266+SanHalacogluImproving@users.noreply.github.com>
acarbonetto
added a commit
that referenced
this pull request
Apr 10, 2024
* Java: Add XADD command (Stream commands) (#155) * Add Stream XADD command to Java Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Java: Add Zpopmax command. (Sorted Set Commands) (#1164) * Java: Add Zpopmax command. (Sorted Set Commands) (#149) * Minor documentation update. * Minor test update. * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Minor documentation update. * Rebase + Spotless --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Clean up merge Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Move xadd command Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update xtrim documentation Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: SanHalacogluImproving <144171266+SanHalacogluImproving@users.noreply.github.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sa1Gur
pushed a commit
to Sa1Gur/glide-for-redis
that referenced
this pull request
Apr 10, 2024
commit 0a430cf Author: Andrew Carbonetto <andrew.carbonetto@improving.com> Date: Wed Apr 10 13:30:02 2024 -0700 Java/Node: Update docs for `xadd` and `xtrim` (valkey-io#1246) * Java: Add XADD command (Stream commands) (valkey-io#155) * Add Stream XADD command to Java Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164) * Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#149) * Minor documentation update. * Minor test update. * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Minor documentation update. * Rebase + Spotless --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Clean up merge Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Move xadd command Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update xtrim documentation Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: SanHalacogluImproving <144171266+SanHalacogluImproving@users.noreply.github.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> commit 4ce976c Author: SanHalacogluImproving <144171266+SanHalacogluImproving@users.noreply.github.com> Date: Wed Apr 10 12:36:56 2024 -0700 Java: Add `Zmscore` command. (Sorted Set Command Group) (valkey-io#1234) * Java: Add Zmscore command. (Sorted Set Command Group) (valkey-io#173) * Minor update + remove change log. * Minor documentation update. * Minor IT update. * Rebase + Spotless. * Minor IT test update. commit ae0a8f4 Author: Yury-Fridlyand <yury.fridlyand@improving.com> Date: Wed Apr 10 12:33:22 2024 -0700 Java: Refactor transaction UT (valkey-io#1242) Refactor transaction UT. (valkey-io#192) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> commit fec74b8 Author: Andrew Carbonetto <andrew.carbonetto@improving.com> Date: Wed Apr 10 12:28:18 2024 -0700 Clean up all warnings in Java client test (valkey-io#1213) * Clean up all warnings in Java client test Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Clean FfiTest.java of warnings Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Clean RedisClusterClientTest.java of compiler warnings Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Clean up more warnings in client tests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix UT + update IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update suppression. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Remove suppress warnings Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> commit 527e1ec Author: SanHalacogluImproving <144171266+SanHalacogluImproving@users.noreply.github.com> Date: Wed Apr 10 12:06:01 2024 -0700 Java: Add `lindex` command. (List Command Group) (valkey-io#1219) * Java: Add lindex command. (List Command Group) (valkey-io#158) * Minor documentation update + changed param from int to long + minor IT update. commit d766f51 Author: Andrew Carbonetto <andrew.carbonetto@improving.com> Date: Wed Apr 10 10:01:55 2024 -0700 Node: Fix build section for node DEVELOPER.md (valkey-io#1250) * Fix build section for node DEVELOPER.md Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix numbers in DEVELOPER.md Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Run prettier --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: Jonathan Louie <jonathanl@bitquilltech.com> commit 939a519 Author: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com> Date: Wed Apr 10 09:08:43 2024 -0700 Java: Use LinkedHashMap instead of HashMap for Java wrapper Map values returned from Redis (valkey-io#1257) * Use LinkedHashMap instead of HashMap for Java wrapper Map values returned from Redis * Run cargo fmt commit d21dbc9 Author: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Date: Wed Apr 10 18:02:22 2024 +0300 add missing examples and minor doc fix (valkey-io#1258) commit 09bec2d Author: ort-bot <glide-for-redis@amazon.com> Date: Wed Apr 10 00:19:09 2024 +0000 Updated attribution files commit 4e7acdc Author: Adan Wattad <119428203+adanWattad@users.noreply.github.com> Date: Wed Apr 10 11:11:21 2024 +0300 Node: added zrange and zrangeWithScores commands. (valkey-io#1115) --------- Co-authored-by: Adan <adanwat@amazon.com> Co-authored-by: Shoham Elias <shohame@amazon.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> commit 79c49a4 Author: Gilboab <97948000+GilboaAWS@users.noreply.github.com> Date: Wed Apr 10 10:53:16 2024 +0300 Python: Added RENAME command (valkey-io#1252) Python: Added rename command commit 78cfa33 Author: Adan Wattad <119428203+adanWattad@users.noreply.github.com> Date: Tue Apr 9 14:29:45 2024 +0300 Node: added spop and spopCount commands. (valkey-io#1117) Co-authored-by: Shoham Elias <shohame@amazon.com> commit 5395fe1 Author: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Date: Tue Apr 9 12:23:59 2024 +0300 Python: adds ZREMRANGEBYSCORE command (valkey-io#1151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to create more clients than the number of concurrent
tasks, since the extra clients won't be used.