Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Add Zpopmax command. (Sorted Set Commands) #1164

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Java: Add Zpopmax command. (Sorted Set Commands) #1164

merged 6 commits into from
Apr 1, 2024

Conversation

SanHalacogluImproving
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SanHalacogluImproving SanHalacogluImproving requested a review from a team as a code owner March 22, 2024 20:22
@acarbonetto acarbonetto added the java issues and fixes related to the java client label Mar 22, 2024
@acarbonetto acarbonetto changed the title Java: Add Zpopmax command. (Sorted Set Commands) (#149) Java: Add Zpopmax command. (Sorted Set Commands) Mar 22, 2024
Yury-Fridlyand
Yury-Fridlyand approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

java/client/src/test/java/glide/api/RedisClientTest.java Outdated Show resolved Hide resolved
jonathanl-bq
jonathanl-bq reviewed Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@jonathanl-bq jonathanl-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the examples don't really demonstrate what the command actually does as is. Maybe you could make them a little more meaningful?

java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java Show resolved Hide resolved
@shohamazon shohamazon assigned shohamazon and unassigned barshaul Apr 1, 2024
@acarbonetto acarbonetto force-pushed the java/integ_SanH_add_Zpopmax branch from b384ea6 to 83dcd9f Compare April 1, 2024 15:37
@SanHalacogluImproving SanHalacogluImproving force-pushed the java/integ_SanH_add_Zpopmax branch from 2a6685b to 1b4987e Compare April 1, 2024 18:43
@Elen-Ghulam Elen-Ghulam merged commit a38b45f into valkey-io:main Apr 1, 2024
12 checks passed
acarbonetto added a commit to Bit-Quill/valkey-glide that referenced this pull request Apr 1, 2024
@SanHalacogluImproving @acarbonetto
Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)
6b054fb 
* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto added a commit to Bit-Quill/valkey-glide that referenced this pull request Apr 1, 2024
@SanHalacogluImproving @acarbonetto
Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)
309210b 
* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto added a commit to Bit-Quill/valkey-glide that referenced this pull request Apr 3, 2024
@SanHalacogluImproving @acarbonetto
Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)
8cf43d0 
* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto added a commit to Bit-Quill/valkey-glide that referenced this pull request Apr 4, 2024
@SanHalacogluImproving @acarbonetto
Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)
f5eae7a 
* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto added a commit to Bit-Quill/valkey-glide that referenced this pull request Apr 4, 2024
@SanHalacogluImproving @acarbonetto
Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)
6000f21 
* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto added a commit to Bit-Quill/valkey-glide that referenced this pull request Apr 8, 2024
@SanHalacogluImproving @acarbonetto
Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)
fead407 
* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
shohamazon pushed a commit to adanWattad/glide-for-redis that referenced this pull request Apr 9, 2024
@SanHalacogluImproving @acarbonetto @shohamazon
Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)
0982c0a 
* Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto added a commit to Bit-Quill/valkey-glide that referenced this pull request Apr 10, 2024
@SanHalacogluImproving @acarbonetto
Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)
ded032b 
* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto added a commit that referenced this pull request Apr 10, 2024
@acarbonetto @SanHalacogluImproving @Yury-Fridlyand
Java/Node: Update docs for xadd and xtrim (#1246)
0a430cf 
* Java: Add XADD command (Stream commands) (#155)

* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Java: Add Zpopmax command. (Sorted Set Commands) (#1164)

* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Clean up merge

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Move xadd command

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* PR comments.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Update xtrim documentation

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: SanHalacogluImproving <144171266+SanHalacogluImproving@users.noreply.github.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
alex-arzola-imp pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Apr 12, 2024
@acarbonetto @SanHalacogluImproving
@Yury-Fridlyand @alex-arzola-imp
Java/Node: Update docs for xadd and xtrim (valkey-io#1246)
1fd9f43 
* Java: Add XADD command (Stream commands) (#155)

* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)

* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Clean up merge

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Move xadd command

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* PR comments.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Update xtrim documentation

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: SanHalacogluImproving <144171266+SanHalacogluImproving@users.noreply.github.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@SanHalacogluImproving SanHalacogluImproving deleted the java/integ_SanH_add_Zpopmax branch April 26, 2024 20:39
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
@SanHalacogluImproving @acarbonetto @cyip10
Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)
84f8c2b 
* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
@acarbonetto @SanHalacogluImproving
@Yury-Fridlyand @cyip10
Java/Node: Update docs for xadd and xtrim (valkey-io#1246)
6a58fa2 
* Java: Add XADD command (Stream commands) (#155)

* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)

* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Clean up merge

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Move xadd command

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* PR comments.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Update xtrim documentation

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Spotless

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: SanHalacogluImproving <144171266+SanHalacogluImproving@users.noreply.github.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanl-bq jonathanl-bq jonathanl-bq left review comments

@shohamazon shohamazon shohamazon approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@barshaul barshaul Awaiting requested review from barshaul

@shachlanAmazon shachlanAmazon Awaiting requested review from shachlanAmazon

Assignees

@shohamazon shohamazon

@SanHalacogluImproving SanHalacogluImproving

Labels
java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SanHalacogluImproving @jonathanl-bq @Yury-Fridlyand @shohamazon @barshaul @acarbonetto @Elen-Ghulam