Update United Kingdom & Isle of Man holidays: add l10n support

[PPsyrius]

Proposed change

Add en_GB, en_US, th localization for the United Kingdom (gb) and Isle of Man (im).

Note

• As the Isle of Man is simply overriding UK's implementation at the moment, both need to have l10n support to work properly. This needs to be factored in for future French/US/Netherlands overseas territories as well i.e. Refactor Aruba/Curaçao as NL subdivision #1852 .
• I have verified that the Isle of Man's government website uses British English (en_GB) rather than the Manx English (en_IM) dialect.
• The current l10n implementation requires all relevant l10n entries to be copied to the overriding entity as well, rather than simply having 5 l10n entries for IM file. This limitation is hopefully resolved in the v1 implementation.

Type of change

• New country/market holidays support (thank you!)
• Supported country/market holidays update (calendar discrepancy fix, localization)
• Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
• Dependency update (version deprecation/pin/upgrade)
• Bugfix (non-breaking change which fixes an issue)
• Breaking change (a code change causing existing functionality to break)
• New feature (new holidays functionality in general)

Checklist

• I've followed the contributing guidelines
• I've successfully run make check, all checks and tests are green

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cb2a27d) to head (6f3a0a1).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2258   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          200       200           
  Lines        12200     12215   +15     
  Branches      1735      1737    +2     
=========================================
+ Hits         12200     12215   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[KJhellico]

Just one small fix:

[arkid15r]

Great PR 👍

[arkid15r]

I was going to merge it, added to the merge queue while test were green.

In parallel I was checking something locally. So it seems that at least at my localhost make l10n (technically it's scripts/l10n/generate_po_files.py) produces some changes specifically in IM.po files. It may be related to the derived from UK situation - the script keeps items that originate from isle_of_man.py file while removing everything else.

I had thought it'd be great if someone else looked at it and removed it from the queue before the CI/CD was done.

[KJhellico]

@PPsyrius, look at my PR in your repo. It seems to be working. 🙂

[arkid15r]

We're going to use parent_entity in v1 so it may be a good idea to introduce it here too in order keep the parent translation logic simple. We can also migrate to composition approach for entities like IM.

@KJhellico @PPsyrius please review and test.

[PPsyrius]

@arkid15r I can confirm that it's now working as intended with your latest changes in ❤️

>>> import holidays
>>> print(holidays.IM(years=2024, language="th"))

{datetime.date(2024, 3, 29): 'วันศุกร์ประเสริฐ', datetime.date(2024, 5, 6): 'วันเมย์เดย์', datetime.date(2024, 5, 27): 'วันหยุดฤดูใบไม้ผลิของธนาคาร', datetime.date(2024, 4, 1): 'วันจันทร์อีสเตอร์', datetime.date(2024, 8, 26): 'วันหยุดช่วงปลายฤดูร้อนของธนาคาร', datetime.date(2024, 6, 7): 'วันแข่งไอร์ออฟแมน ทีที', datetime.date(2024, 7, 5): 'วันไทน์วอลด์', datetime.date(2024, 1, 1): 'วันขึ้นปีใหม่', datetime.date(2024, 12, 25): 'วันคริสต์มาส', datetime.date(2024, 12, 26): 'วันเปิดกล่องของขวัญ'}

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[KJhellico]

LGTM!