Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePattern should be moved to a shared package #171

Closed
vaadin-miki opened this issue Jun 22, 2020 · 0 comments · Fixed by #172
Closed

DatePattern should be moved to a shared package #171

vaadin-miki opened this issue Jun 22, 2020 · 0 comments · Fixed by #172
Assignees
@vaadin-miki
Labels
api All things related with adding, removing and modifying public API.
Milestone
0.7.0 - SuperText...

Comments

@vaadin-miki
Copy link
Owner

vaadin-miki commented Jun 22, 2020 •
edited
Loading

HasDatePattern is declared as a marker interface and it relies on DatePattern, currenly in superfields.dates. That package contains also implementations of the HasDatePattern interface, which causes a cyclic dependency.

The dependency should be broken by moving the DatePattern class info a shared.dates package.
@vaadin-miki vaadin-miki self-assigned this Jun 22, 2020
@vaadin-miki vaadin-miki added this to the 0.7.0 - SuperTextField milestone Jun 22, 2020
@vaadin-miki vaadin-miki added the api All things related with adding, removing and modifying public API. label Jun 22, 2020
vaadin-miki added a commit that referenced this issue Jun 22, 2020
@vaadin-miki
#171 DatePattern now in a separate package
bb84ead
@vaadin-miki vaadin-miki mentioned this issue Jun 22, 2020
Merged
vaadin-miki added a commit that referenced this issue Jun 22, 2020
@vaadin-miki
#171 DatePattern now in a separate package (#172)
ab9bcca
vaadin-miki added a commit that referenced this issue Jun 22, 2020
@vaadin-miki
#171 DatePattern now in a separate package (#172)
db287ba
vaadin-miki added a commit that referenced this issue Jun 22, 2020
@vaadin-miki
Release 0.7.0 ready (#169)
be67db6 
done #100 #105 #108 #107 #111 #113 #115 #117 #119 #22 #124 #126 #127 #129 #132 #122 #136 #137 #123 #141 #139 #143 #135 #146 #147 #152 #154 #131 #171
vaadin-miki added a commit that referenced this issue Jul 1, 2020
@vaadin-miki
Release 0.7.1 ready (#181)
7c7d9eb 
done #171 #173 #178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaadin-miki vaadin-miki

Labels
api All things related with adding, removing and modifying public API.
Projects
None yet
Milestone
0.7.0 - SuperTextField
Development

Successfully merging a pull request may close this issue.

#171 DatePattern now in a separate package vaadin-miki/super-fields
1 participant
@vaadin-miki