Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve conflicts automatically when making new release #131

Closed
vaadin-miki opened this issue May 29, 2020 · 3 comments
Closed

Resolve conflicts automatically when making new release #131

vaadin-miki opened this issue May 29, 2020 · 3 comments
Assignees

Comments

@vaadin-miki
Copy link
Owner

During automated release process some files are modified, which causes conflicts when creating a new release.

Find a way to automatically accept changes from the incoming (release) branch when making a PR to master.

@vaadin-miki vaadin-miki self-assigned this May 29, 2020
vaadin-miki added a commit that referenced this issue Jun 10, 2020
vaadin-miki added a commit that referenced this issue Jun 10, 2020
vaadin-miki added a commit that referenced this issue Jun 10, 2020
vaadin-miki added a commit that referenced this issue Jun 11, 2020
vaadin-miki added a commit that referenced this issue Jun 11, 2020
vaadin-miki added a commit that referenced this issue Jun 11, 2020
vaadin-miki added a commit that referenced this issue Jun 11, 2020
vaadin-miki added a commit that referenced this issue Jun 11, 2020
vaadin-miki added a commit that referenced this issue Jun 13, 2020
vaadin-miki added a commit that referenced this issue Jun 13, 2020
vaadin-miki added a commit that referenced this issue Jun 13, 2020
@vaadin-miki
Copy link
Owner Author

release notes must be updated separately to development before the release-X.Y.Z branch gets created

so the workflow should be: close milestone -> make branch for release notes -> make release notes -> make pr to development -> accept PR -> create release-X.Y.Z branch -> update versions in that branch -> merge master into that branch, using --strategy=ours -> create PR from release-X.Y.Z into master

vaadin-miki added a commit that referenced this issue Jun 16, 2020
vaadin-miki added a commit that referenced this issue Jun 16, 2020
vaadin-miki added a commit that referenced this issue Jun 16, 2020
@vaadin-miki
Copy link
Owner Author

alrighty, more additional steps: since development is protected by checks, a PR must be made for release notes separately, and ideally there is another workflow fired when that PR is ready to be closed and closes it

@vaadin-miki
Copy link
Owner Author

vaadin-miki commented Jun 17, 2020

this is great... according to the docs and support check_suite events are not triggered from the default actions workflow, which means on: status events should be used

https://github.uint.cloudmunity/t/on-check-suite-never-triggers-why/17303/6

vaadin-miki added a commit that referenced this issue Jun 21, 2020
this should now merge the PR after a delay of 300 seconds, which should be more than enough for the actions to pass successfully
vaadin-miki added a commit that referenced this issue Jun 21, 2020
this should now merge the PR after a delay of 300 seconds, which should be more than enough for the actions to pass successfully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant