Cancel button in post edit page #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angamanga
requested changes
Feb 12, 2020
| @@ -69,7 +69,7 @@ | |||
| <div class="toolbar toolbar-secondary"> | |||
| <div class="button-group"> | |||
|
|
|||
| <button class="button-flat" ng-click="leavePost()" translate>app.cancel</button> | |||
There was a problem hiding this comment.
Good job finding your way to this!
| @@ -89,6 +89,10 @@ function PostDataEditorController( | |||
| $scope.selectForm = selectForm; | |||
| $scope.isSaving = LoadingProgress.getSavingState; | |||
|
|
|||
| $scope.cancel = function () { | |||
| $location.path('/views/data'); | |||
There was a problem hiding this comment.
We want to keep the post selected here, instead of going to the general data-view. Hint: if you look at this row (its the function for the upper cancel-button in the "toolbar"): https://github.com/ushahidi/platform-client/blob/develop/app/main/posts/views/post-toolbar.directive.js#L53, it goes to the data-view with the post still selected.
|
@himil-vasava Looks good, you are on the right track, just a minor change, see my comment! |
|
@Angamanga I have made the changes requested by you. Are they okay? |
|
@Angamanga @tuxpiper can u check it please? |
Angamanga
approved these changes
Feb 24, 2020
|
@himil-vasava Looks great now! Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Before Changes:
The cancel button in the post edit page was not working.
After Changes:
As the cancel button is clicked the edit mode is cancelled and it goes back to post view.
Testing checklist:
Fixes ushahidi/platform#3828 .
Ping @ushahidi/platform