Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel-button in the bottom of the edit-post-page is not working #3828

Closed
Angamanga opened this issue Dec 18, 2019 · 11 comments · Fixed by ushahidi/platform-client#1428
Closed
Assignees
Labels
Bug Codebase: Client Indicates issue work will be in client good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Stage: In progress Theme: Forms
Milestone

Comments

@Angamanga
Copy link
Contributor

Angamanga commented Dec 18, 2019

Describe the bug
When clicking on the cancel-button in the bottom of the edit-post-page, nothing is happening

Where was the bug observed
Local environment with Vagrant.

To Reproduce
Steps to reproduce the behavior:

  1. Go to data-view
  2. Log in as admin or manage-posts
  3. Click a post and select Edit
  4. Scroll down to the bottom of the edit-view
  5. Click cancel
  6. Nothing happens

Expected behavior
The editmode should cancel and go back to post-view (or show a modal asking if the user really wants to leave if changes are made)

Is there a workaround? What is it.
Click on the cancel-button in the upper-right corner

Screenshots
Screenshot 2019-12-18 at 12 01 53

URL / Environment where this happened
localhost:3000

Desktop Hardware Details (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [chrome]

Aha! Link: https://ushahiditeam.aha.io/features/PROD-160

@rowasc rowasc added good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Theme: Forms Bug Codebase: Client Indicates issue work will be in client labels Jan 2, 2020
@bismitaguha
Copy link

@Angamanga @rowasc can I work on this issue?

@rowasc
Copy link
Contributor

rowasc commented Jan 9, 2020

absolutely, thank you so much for checking! @bismitaguha assigning it to you

@rohit645
Copy link

@rowasc Can I work on this issue?

@Angamanga
Copy link
Contributor Author

@bismitaguha Are you still working on this issue?

@Erioldoesdesign
Copy link

I would love for the cancel button colour contrast to be fixed some day...maybe using #222222 for the text colour and #8E9297 for the background.
Screenshot 2020-02-22 at 10 00 15

@Angamanga
Copy link
Contributor Author

Angamanga commented Feb 24, 2020

@Obadha2 Could you QA in Steve Buscemi please? Testing-checklist:

  • As logged in, go to dataview and select a post
  • Click on edit
  • Make a change
  • Click on cancel in the bottom of the edit page
  • An dialog-box should appear
  • Click on "Continue without saving"
  • You should leave edit-mode and the post should still be selected
  • Click on edit
  • Make a change
  • Click on cancel in the bottom of the edit page
  • Click on "Save" in the dialoge
  • The post should save
  • You should leave the edit-mode and the post should still be selected

@Angamanga Angamanga reopened this Feb 24, 2020
@AmTryingMyBest
Copy link
Contributor

QA'd, passes. 👍

@tuxpiper
Copy link
Member

tuxpiper commented Mar 7, 2020

@all-contributors please add @himil-vasava for code

@allcontributors
Copy link
Contributor

@tuxpiper

I've put up a pull request to add @himil-vasava! 🎉

@rowasc rowasc added this to the Parking Lot milestone Sep 4, 2020
@GunjanRajTiwari
Copy link

Is this issue solved?
If not can I work on it?

@Angamanga
Copy link
Contributor Author

@GunjanRajTiwari This one is unfortunately already solved, closing it. Take a look at the issues in the "Ready for development" here: https://github.com/ushahidi/platform/projects/11. Ping me in any issue you want to work on! 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Codebase: Client Indicates issue work will be in client good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Stage: In progress Theme: Forms
Projects
None yet
8 participants