Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enabling all platforms when selecting maui #291

Merged
merged 9 commits into from
Sep 20, 2023
Merged

Conversation

nickrandolph
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

When selecting maui (-maui) platforms that don't support maui are removed

What is the new behavior?

When selecting maui platform selection isn't modified
Maui embedding is selectively included based on tfm

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph marked this pull request as ready for review September 19, 2023 09:40
@dansiegel dansiegel enabled auto-merge September 19, 2023 15:29
@dansiegel dansiegel merged commit 4b6fec5 into main Sep 20, 2023
@dansiegel dansiegel deleted the dev/nr/allplatforms branch September 20, 2023 02:51
@nickrandolph
Copy link
Contributor Author

@Mergifyio backport legacy/4x release/stable/4.10

@mergify
Copy link

mergify bot commented Sep 20, 2023

backport legacy/4x release/stable/4.10

✅ Backports have been created

nickrandolph added a commit that referenced this pull request Sep 20, 2023
feat: Enabling all platforms when selecting maui (backport #291)
nickrandolph added a commit that referenced this pull request Sep 20, 2023
…10/pr-291

feat: Enabling all platforms when selecting maui (backport #291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants