Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding maui and not_maui namespace definitions #1902

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

nickrandolph
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

No custom namespaces for conditional xaml based on whether running on maui target or not

What is the new behavior?

Can use maui and not_maui namespace prefixes to show different content depending on whether running on a maui target or not

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph marked this pull request as ready for review September 18, 2023 15:22
@nickrandolph
Copy link
Contributor Author

Part of unoplatform/uno.templates#291

@dansiegel dansiegel enabled auto-merge September 18, 2023 15:32
@dansiegel dansiegel merged commit 441cb5c into main Sep 18, 2023
@dansiegel dansiegel deleted the dev/nr/mauinamespaces branch September 18, 2023 16:03
@nickrandolph
Copy link
Contributor Author

@mergify backport legacy/2x release/stable/2.5

@mergify
Copy link

mergify bot commented Sep 19, 2023

backport legacy/2x release/stable/2.5

✅ Backports have been created

nickrandolph added a commit that referenced this pull request Sep 19, 2023
….5/pr-1902

feat: Adding maui and not_maui namespace definitions (backport #1902)
nickrandolph added a commit that referenced this pull request Oct 2, 2023
feat: Adding maui and not_maui namespace definitions (backport #1902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants