Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change Assign usage for Name #2194

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Conversation

eriklimakc
Copy link
Contributor

@eriklimakc eriklimakc commented Mar 8, 2024

Must be merged after #2185

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the new behavior?

Changing .Assign(out var fe) usage for .Name(out var fe) in docs.

@eriklimakc eriklimakc self-assigned this Mar 8, 2024
@eriklimakc
Copy link
Contributor Author

In this second example below, should we leave it as is? If we change it to use .Name(out var slider) it would then be exactly the same as the first one.

```cs
new Slider().Name(out var slider),
new TextBlock()
.Text(x => x
.Source(slider)
.Binding(() => slider.Value))
```
The second is that we can leverage the element name for our binding such as the following:
```cs
new TextBlock()
.Text(x => x
.Source("slider")
.Binding(() => slider.Value)),
new Slider().Name("slider")
```

cc @Youssef1313 @dansiegel

@eriklimakc
Copy link
Contributor Author

Should this be changed to .Name(out var myAnimatedRectangle)?

```cs
new Rectangle().Name("MyAnimatedRectangle");
```

cc @Youssef1313 @dansiegel

@eriklimakc eriklimakc marked this pull request as ready for review March 20, 2024 13:06
@eriklimakc eriklimakc added the kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project label Apr 11, 2024
@kazo0
Copy link
Contributor

kazo0 commented Apr 11, 2024

@Mergifyio backport release/stable/4.1

Copy link

mergify bot commented Apr 11, 2024

backport release/stable/4.1

✅ Backports have been created

@dansiegel dansiegel merged commit 80cf840 into main Apr 15, 2024
6 of 7 checks passed
@dansiegel dansiegel deleted the dev/erli/name-doc-updates branch April 15, 2024 13:32
agneszitte added a commit that referenced this pull request Apr 15, 2024
….1/pr-2194

docs: Change Assign usage for Name (backport #2194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants