Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new binding updates #2185

Merged
merged 5 commits into from
Mar 15, 2024
Merged

chore: new binding updates #2185

merged 5 commits into from
Mar 15, 2024

Conversation

vatsashah45
Copy link
Contributor

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Updated the documentation with new binding updates.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@vatsashah45 vatsashah45 self-assigned this Feb 23, 2024
doc/Learn/Markup/SourceUsage.md Outdated Show resolved Hide resolved
doc/Learn/Markup/SourceUsage.md Outdated Show resolved Hide resolved
doc/Learn/Markup/SourceUsage.md Outdated Show resolved Hide resolved
doc/Learn/Markup/SourceUsage.md Outdated Show resolved Hide resolved
doc/Learn/Markup/SourceUsage.md Outdated Show resolved Hide resolved
doc/Learn/Markup/SourceUsage.md Outdated Show resolved Hide resolved
doc/Learn/Markup/SourceUsage.md Outdated Show resolved Hide resolved
doc/Learn/Markup/SourceUsage.md Outdated Show resolved Hide resolved
doc/Learn/Markup/SourceUsage.md Outdated Show resolved Hide resolved
doc/Learn/Markup/SourceUsage.md Outdated Show resolved Hide resolved
@eriklimakc
Copy link
Contributor

I'm not quite sure about this example here, does it still make sense? What would be the changes for this example regarding the API changes?

new MyCustomControl()
.DataContext(x => x
.Source(this)
.Binding(() => this.DataContext)
.Convert(dataContext => {
if (dataContext is MyViewModel myViewModel)
{
return new MyCustomControlViewModel(myViewModel.SomeContext);
}
return null;
})
.OneTime()

cc @dansiegel @nickrandolph

@nickrandolph
Copy link
Contributor

nickrandolph commented Mar 15, 2024

@vatsashah45 I've approved these changes but I think we need to add some docs that point out the now deprecated Bind syntax and confirm that "Binding" is the equivalent of "Path" in XAML

@nickrandolph nickrandolph merged commit 7327789 into main Mar 15, 2024
6 of 7 checks passed
@nickrandolph nickrandolph deleted the dev/vs/binding-doc-updates branch March 15, 2024 04:15
Copy link

welcome bot commented Mar 15, 2024

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants