Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding default routes for hard coded regions #2152

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Jan 22, 2024

GitHub Issue (If applicable): closes #2151

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

See issue

What is the new behavior?

No reflection loopup for hardcoded regions

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph merged commit cabea8b into main Jan 22, 2024
15 of 16 checks passed
@nickrandolph nickrandolph deleted the dev/nr/noroutetabs branch January 22, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation] Avoid using reflection when accessing hardcoded regions
2 participants