Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correcting calculation of navigated route #2148

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): closes #2147

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

(see issue)

What is the new behavior?

Fix: command line arguments are correctly added to configuration via hosting - this enables testing of startup navigation by setting commandline in launchsettings eg
image

Fix: correct calculation of navigated route to only include segments that appeared in the original route

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph merged commit c17484a into main Jan 22, 2024
14 of 15 checks passed
@nickrandolph nickrandolph deleted the dev/nr/net8only branch January 22, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation] Deeplinking not working when DependsOn used in routes
2 participants