Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation] Deeplinking not working when DependsOn used in routes #2147

Closed
16 tasks
nickrandolph opened this issue Jan 22, 2024 · 0 comments · Fixed by #2148
Closed
16 tasks

[Navigation] Deeplinking not working when DependsOn used in routes #2147

nickrandolph opened this issue Jan 22, 2024 · 0 comments · Fixed by #2148
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@nickrandolph
Copy link
Contributor

Current behavior

When a "DependsOn" link is defined in the routemap navigation fails to sub-paths. For example in Playground, if you open the NavigationView and click on Products the relative path is /NavigationView/Products. When attempting to navigate to this the NavigationViewPage is correctly navigated to but the navigated path is calculated as /Home/NavigationView (since Home is DependsOn for the NaivgationView route). This causes a perpetual loop because the NavigationView can't be stripped from the original request, since Home doesn't appear in the original request.

Expected behavior

Calculated navigated route should only include segments that were in the original route request

How to reproduce it (as minimally and precisely as possible)

Launch Playground on WASM
Open Navigation and Click Products
Address bar should include NavigationView/Products
Click refresh on browser - this won't ever succeed

Environment

Nuget Package (s):

Package Version(s):

Affected platform(s):

  • iOS
  • macOS (AppKit)
  • Mac Catalyst
  • Android
  • WebAssembly
  • Windows
  • Skia (WPF)
  • Skia (GTK on Linux/macOS/Windows)
  • Skia (Linux Framebuffer)
  • Build tasks

Visual Studio:

  • 2019 (version: )
  • 2022 (version: )
  • Visual Studio Code (version: )
  • Rider Windows (version: )
  • Rider macOS (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?

@nickrandolph nickrandolph added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Jan 22, 2024
@nickrandolph nickrandolph changed the title Deeplinking not working when DependsOn used in routes [Navigation] Deeplinking not working when DependsOn used in routes Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant