Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add AdditionalFiles metadata to ensure proper deduplication (backport #2105) #2115

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 19, 2023

This is an automatic backport of pull request #2105 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

This change aligns `AdditionalFiles` with `_InjectAdditionalFiles` from Uno source generators, which may duplicate content based on the absence of `SourceItemGroup`.

This would cause hot reload to fail silently because of duplicate `AdditionalFiles` entries.

(cherry picked from commit f72c6e7)
@jeromelaban jeromelaban disabled auto-merge December 19, 2023 18:40
@jeromelaban jeromelaban merged commit 9d6ac73 into release/stable/3.0 Dec 19, 2023
8 of 11 checks passed
@jeromelaban jeromelaban deleted the mergify/bp/release/stable/3.0/pr-2105 branch December 19, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant