fix: Add AdditionalFiles metadata to ensure proper deduplication #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aligns `AdditionalFiles` with `_InjectAdditionalFiles` from Uno source generators, which may duplicate content based on the absence of `SourceItemGroup`. This would cause hot reload to fail silently because of duplicate `AdditionalFiles` entries.
nickrandolph
approved these changes
Dec 14, 2023
|
@Mergifyio backport release/stable/3.0 |
✅ Backports have been created
|
jeromelaban
added a commit
that referenced
this pull request
Dec 19, 2023
….0/pr-2105 fix: Add AdditionalFiles metadata to ensure proper deduplication (backport #2105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the new behavior?
This change aligns
AdditionalFileswith_InjectAdditionalFilesfrom Uno source generators, which may duplicate content based on the absence ofSourceItemGroup.This would cause hot reload to fail silently because of duplicate
AdditionalFilesentries.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):