Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix small_test.sh CLI command to deal with spaces in paths #152

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

willzeng
Copy link
Collaborator

@willzeng willzeng commented Jan 1, 2025

This is a small fix for a bug that came up when I had a space in my general path.

@willzeng willzeng added the bug Something isn't working label Jan 1, 2025
@willzeng
Copy link
Collaborator Author

willzeng commented Jan 1, 2025

I have added an additional change here to pin the python version that is called to 3.12.

Are we able to upgrade to support 3.13 at some point?

@Misty-W
Copy link
Collaborator

Misty-W commented Jan 2, 2025

thanks for fixing this @willzeng! We added support for python 3.13 in #77. Did you come across an issue with 3.13?

@willzeng
Copy link
Collaborator Author

willzeng commented Jan 2, 2025

Looks good so far! A small versioning issue #154 but good to go. I have removed the change here and it is not just the small change to the path and so ready for review.

Copy link
Collaborator

@Misty-W Misty-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @willzeng!

I'll take a look at #154 separately.

@Misty-W Misty-W merged commit 807a57b into main Jan 2, 2025
1 check passed
@Misty-W Misty-W deleted the path-cli-bugfix branch January 2, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants