Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CICE (2025-01) + Feature/cicd bugfix to save metrics result files #2592 + Remove Expanse/Odin/Stampede & Update Orion/Hercules lmod init script location #2570 #2569

Merged
merged 41 commits into from
Feb 10, 2025

Conversation

NickSzapiro-NOAA
Copy link
Collaborator

@NickSzapiro-NOAA NickSzapiro-NOAA commented Jan 24, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Merge authoritative CICE-Consortium:main into EMC fork, including baseline changes in outgoing lw for history and coupling and Icepack related to ponds

Commit Message:

* UFSWM - Update CICE to Consortium/main (2025-01)
* UFSWM - Rm Expanse/Stampede/Odin & update Orion/Hercules lmod init location
* UFSWM - Save cicd automation metrics in WORKSPACE
  * CICE - Update CICE to Consortium/main (2025-01)

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@NickSzapiro-NOAA NickSzapiro-NOAA self-assigned this Jan 24, 2025
@NickSzapiro-NOAA NickSzapiro-NOAA added the Baseline Updates Current baselines will be updated. label Jan 24, 2025
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Feb 5, 2025

@NickSzapiro-NOAA #2487 is not perfectly ready yet. We can let this PR move first. Can you sync up branch? And we can combine in #2579 and #2570 to this pr. It will be appreciated if you merge in those two PRs to this pr. @BrianCurtis-NOAA @FernandoAndrade-NOAA FYI

@NickSzapiro-NOAA
Copy link
Collaborator Author

@jkbk2004 @RatkoVasic-NOAA @gspetro-NOAA Please let me know if this looks ok

@NickSzapiro-NOAA
Copy link
Collaborator Author

Are we reverting adding 2579 here?

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Feb 7, 2025

Are we reverting adding 2579 here?

@NickSzapiro-NOAA Yes, #2579 will go separately.

@NickSzapiro-NOAA
Copy link
Collaborator Author

Ah, ok. Thanks for already doing this @jkbk2004

@FernandoAndrade-NOAA FernandoAndrade-NOAA changed the title Update CICE (2025-01) Update CICE (2025-01) + Feature/cicd bugfix to save metrics result files #2592 Feb 7, 2025
@FernandoAndrade-NOAA FernandoAndrade-NOAA changed the title Update CICE (2025-01) + Feature/cicd bugfix to save metrics result files #2592 Update CICE (2025-01) + Feature/cicd bugfix to save metrics result files #2592 + Remove Expanse/Odin/Stampede & Update Orion/Hercules lmod init script location #2570 Feb 7, 2025
@NickSzapiro-NOAA
Copy link
Collaborator Author

Merged at EMC/CICE @jkbk2004 @FernandoAndrade-NOAA

jkbk2004
jkbk2004 previously approved these changes Feb 10, 2025
@jkbk2004
Copy link
Collaborator

@NickSzapiro-NOAA can we catch up latest FV3 hash update ? NOAA-EMC/fv3atm@2c7357b. Just FV3 PR template update from the commit.

@jkbk2004 jkbk2004 merged commit d57779f into ufs-community:develop Feb 10, 2025
4 checks passed
@DeniseWorthen
Copy link
Collaborator

This is where #2527 would be useful, rather than relying on CMs needing to 'keep an eye' on the performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants