-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync to CICE-Consortium/main (2025-01-23) #99
Sync to CICE-Consortium/main (2025-01-23) #99
Conversation
…3.2.0 (CICE-Consortium#1000) Update Icepack to #fa56e7e387b1, needed for cce/17.0.0 Cleaned up some trailing blanks.
This is a two-line change in ice_flux.F90 (scale_fluxes) to check for the condition where aice > 0, but flwout > -puny (effectively zero). This means the cell was ice free at the beginning of the step, but non-zero at the end. It sets the outgoing longwave to the open ocean value based on the freezing temperature. This is bfb, but will change the history output of flwup and flwup_ai. Test results are coming.
… bfb (CICE-Consortium#1002) Update Icepack to #43ead56380b, hocn and flushing velocity issue, not bfb. See CICE-Consortium/Icepack#504
…via UFS configuration as for other components (CICE-Consortium#1001) * No ncat,ntrcr in call icepack_aggregate in ice_prescribed_mod.F90 * Enable writing restarts that can be triggered at any forecast time ("restart_fh") via UFS configuration as for other components Part of ufs-community/ufs-weather-model#2348 * Add 1 more #ifndef CESMCOUPLED to avoid unused variable warning for cesm * #ifndef for dtime here too
…ium#1003) Update derecho gnu to support code coverage testing Update to ncarenv/24.12 and gcc/12.4.0 Add coverage compiler flags Update lcov scripting as needed As part of the CICE port to the new coverage tools, a bug was found in the tools that requires debug flags to be disabled when compiling with coverage flags. This was not the case when coverage was running on cheyenne. See linux-test-project/lcov#385
@NickSzapiro-NOAA I see you mention that the Icepack update is not B4B. But the lwout change---wouldn't that also change answers? |
@DeniseWorthen Yes, thank you. I've updated summary. I removed my baselines for disk space but will take another look at cpld_control_gfsv17 RT for sanity check |
The results are somewhat weird/confusing and get into if cice gridcell has ice and if fluxes are per unit ice area Copying CICE-Consortium#67 (comment) as helpful: We don't currently output flwup_ai. Here is flwup_1 from the daily-averaged timestep output for current baseline (left) and PR update (right), with a colorbar that goes [-1000, -100] W/m2 on purpose: In FV3, ulwrf doesn't show these and diffs are ~O(10 W/m2) after 24 h. Note that there is still open issue on what do in CICE for coupling when aice comes from or goes to zero |
I had a hard time following the exact back/forth on Consortium, but of course since we're using the same cap, we also divide by aice before exporting (scale_fluxes). I've known about the difference between f()_ai and just f(). It's my understanding that f()_ai is the time averaged value of the ai-weighted field; that won't be the same as mean(f)*mean(ai). I think this is an issue when they decided to save only daily output f() and ai() for CICE but I don't think I was able to convince anyone. |
Testing on 2569 is complete, please continue with merging, thank you. |
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Merge authoritative CICE-Consortium:main into EMC fork, including baseline changes in outgoing lw for history and coupling and Icepack related to ponds
Tony Craig, Dave Bailey, David Clemens-Sewall, Nick Szapiro
UFS regression testing, see Update CICE (2025-01) + Feature/cicd bugfix to save metrics result files #2592 + Remove Expanse/Odin/Stampede & Update Orion/Hercules lmod init script location #2570 ufs-community/ufs-weather-model#2569
EMC/CICE sync to authoritative upstream with baseline changes. Closes #98