Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync to CICE-Consortium/main (2025-01-23) #99

Merged

Conversation

NickSzapiro-NOAA
Copy link
Collaborator

@NickSzapiro-NOAA NickSzapiro-NOAA commented Jan 24, 2025

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Merge authoritative CICE-Consortium:main into EMC fork, including baseline changes in outgoing lw for history and coupling and Icepack related to ponds
  • Developer(s):
    Tony Craig, Dave Bailey, David Clemens-Sewall, Nick Szapiro
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    UFS regression testing, see Update CICE (2025-01) + Feature/cicd bugfix to save metrics result files #2592 + Remove Expanse/Odin/Stampede & Update Orion/Hercules lmod init script location #2570  ufs-community/ufs-weather-model#2569
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

EMC/CICE sync to authoritative upstream with baseline changes. Closes #98

apcraig and others added 6 commits November 27, 2024 08:43
…3.2.0 (CICE-Consortium#1000)

Update Icepack to #fa56e7e387b1, needed for cce/17.0.0

Cleaned up some trailing blanks.
This is a two-line change in ice_flux.F90 (scale_fluxes) to check for the condition where aice > 0, but flwout > -puny (effectively zero). This means the cell was ice free at the beginning of the step, but non-zero at the end. It sets the outgoing longwave to the open ocean value based on the freezing temperature. This is bfb, but will change the history output of flwup and flwup_ai. Test results are coming.
… bfb (CICE-Consortium#1002)

Update Icepack to #43ead56380b, hocn and flushing velocity issue, not bfb.

See CICE-Consortium/Icepack#504
…via UFS configuration as for other components (CICE-Consortium#1001)

* No ncat,ntrcr in call icepack_aggregate in ice_prescribed_mod.F90

* Enable writing restarts that can be triggered at any forecast time ("restart_fh") via UFS configuration as for other components

Part of ufs-community/ufs-weather-model#2348

* Add 1 more #ifndef CESMCOUPLED to avoid unused variable warning for cesm

* #ifndef for dtime here too
…ium#1003)

Update derecho gnu to support code coverage testing

    Update to ncarenv/24.12 and gcc/12.4.0
    Add coverage compiler flags
    Update lcov scripting as needed

As part of the CICE port to the new coverage tools, a bug was found in the tools that requires debug flags to be disabled when compiling with coverage flags. This was not the case when coverage was running on cheyenne. See linux-test-project/lcov#385
@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Feb 5, 2025

@NickSzapiro-NOAA I see you mention that the Icepack update is not B4B. But the lwout change---wouldn't that also change answers?

@NickSzapiro-NOAA
Copy link
Collaborator Author

@DeniseWorthen Yes, thank you. I've updated summary. I removed my baselines for disk space but will take another look at cpld_control_gfsv17 RT for sanity check

@NickSzapiro-NOAA
Copy link
Collaborator Author

NickSzapiro-NOAA commented Feb 6, 2025

The results are somewhat weird/confusing and get into if cice gridcell has ice and if fluxes are per unit ice area

Copying CICE-Consortium#67 (comment) as helpful:
"flwup in history is flwout elsewhere in the code, and in the code calculations this is the value only over sea ice. However it’s later divided by aice for the cesm coupler, and that happens before it’s sent to history. flwup_ai in history is flwout*aice, so it’s back to the only-over-ice value."

We don't currently output flwup_ai. Here is flwup_1 from the daily-averaged timestep output for current baseline (left) and PR update (right), with a colorbar that goes [-1000, -100] W/m2 on purpose:
flwup_baseline_ciceSync_1day
to highlight that for this PR (right) there are "blue outlines" where flwup<-1000 W/m2. These are associated with low aice (like 1E-6).

In FV3, ulwrf doesn't show these and diffs are ~O(10 W/m2) after 24 h.
I've poked around and it looks a bit weird but seems ok

Note that there is still open issue on what do in CICE for coupling when aice comes from or goes to zero

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Feb 6, 2025

I had a hard time following the exact back/forth on Consortium, but of course since we're using the same cap, we also divide by aice before exporting (scale_fluxes).

I've known about the difference between f()_ai and just f(). It's my understanding that f()_ai is the time averaged value of the ai-weighted field; that won't be the same as mean(f)*mean(ai). I think this is an issue when they decided to save only daily output f() and ai() for CICE but I don't think I was able to convince anyone.

@FernandoAndrade-NOAA
Copy link

Testing on 2569 is complete, please continue with merging, thank you.

@NickSzapiro-NOAA NickSzapiro-NOAA merged commit 4411a15 into NOAA-EMC:develop Feb 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync with CICE-Consortium (2025-01)
6 participants