Merge NCAR:main to ufs-community:ufs/dev + update GF/C3 for SRW3.0 release #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_phys_time_vary.scm.F90
UFS-dev PR#73
UFS-dev PR#77
Fix SCM link in readme
UFS-dev PR#85
UFS-dev PR#78
UFS-dev PR#88
Move statement testing the is_initialized variable until after control variables in the argument list have been set. This is needed to make sure that the control variables are set for multiple instances of physics.
Moved is_initialized test to after the input flags have been set
mzhangw
reviewed
Feb 10, 2025
MicroTed
approved these changes
Feb 10, 2025
joeolson42
reviewed
Feb 11, 2025
| @@ -350,12 +351,12 @@ MODULE module_bl_mynn | |||
| CONTAINS | |||
|
|
|||
| ! ================================================================== | |||
| !>\ingroup gsd_mynn_edmf | |||
| !! This subroutine is the GSD MYNN-EDNF PBL driver routine,which | |||
| !>\ingroup gp_mynnedmf | |||
There was a problem hiding this comment.
What is gp? can it be dumped?
There was a problem hiding this comment.
Short for "group"? I dunno. @mzhangw Can you shed any light on this?
There was a problem hiding this comment.
Yes, it is short for "group"
joeolson42
approved these changes
Feb 11, 2025
Qingfu-Liu
approved these changes
Feb 11, 2025
14 tasks
RuiyuSun
approved these changes
Feb 11, 2025
mzhangw
approved these changes
Feb 11, 2025
HelinWei-NOAA
approved these changes
Feb 11, 2025
|
All tests are done at ufs-community/ufs-weather-model#2601. @grantfirl @rhaesung @dustinswales can you merge this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings changes that have come in from the NCAR:main branch back to the ufs-community:ufs/dev branch. Most of the file changes are only documentation changes. The documentation can be viewed here.
Non-documentation changes are as follows:
is_initializedsetting in GFS_rrtmg[p]_setup to support NRL's need for multiple instances of physics in one executableThis was also combined with #249 from @haiqinli. His description for that work is as follows:
Update the GF/C3 for the SRW 3.0.0 release. It includes some of the GF/C3 updates implemented for RRFSv1 and still was successful in reproducing predicted severe storms. It also includes the simplified cold pool parameterization for C3.