Release 0.7.0 #297
Merged
Release 0.7.0 #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are implemented base on CASE normalization practices, and by adapting a recursive-Make normalization pattern from the CASE-Examples-QC repository. `lib/Makfile` was copied directly from CASE 0.3.0. `src/review.mk` was adapted from the CASE-Examples-QC repository's `normalize` recipe. It now uses GNU Make functionality to identify ontology file directories and sometimes-present Turtle files (esp. `*-da.ttl`), instead of hard-coding file references that might be forgotten to be updated over time. References: * [CASE ONT-251] (CP-16) Establish unit tests, possibly Continuous Integration, for ontology repository * [CASE-Examples-QC] https://github.com/ajnelson-nist/CASE-Examples-QC * [OC-98] (CP-39) UCO should implement CI including at least rdf-toolkit runs Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Unit testing revealed this file had unsorted content. No semantic changes are made in this patch. References: * [OC-98] (CP-39) UCO should implement CI including at least rdf-toolkit runs Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Implement CI based on rdf-toolkit and 'make check' design pattern
The proposal filed in Issue 160 changed the type of partitionID to be a string instead of an integer. Unfortunately, one update point was missed. (Patch v2: I did not realize that rdf-toolkit also has a "Hidden" Restriction sort key, by onDataRange before onProperty. Branch name was also of incorrect form.) References: * [Issue 160] Change Proposal: Revise range and documentation of partitionID * [OC-120] (CP-46) DiskPartitionFacet accidentally has partitionID range as xsd:integer Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [OC-99] (CP-38) NTFSFileSystemFacet describes an NTFS file, not file system Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [OC-34] (CP-52) observable:nameserver should be camel-cased Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Spell observable:nameserver with camel-casing
Add missed update for partitionID type
This patch is a revision to the implementation of CP-39, to guarantee the visit order of subdirectories. While undergoing an in-depth normalization review of each Turtle file today, I and a person I was working with realized that the visit order of subdirectories was non-deterministic between Make runs. On the scale of nuisances, this is minor, as it causes some confusion on when a per-file review will be completed, but does not cause any true review errors because UCO's subdirectories are all independently reviewable. (The non-determinimism was not apparent in my reviews for the initial patch because my testing tended to run with full parallelism from 'make -j'.) Aside from directory and file visit order, no semantic or behavioral changes are made in this patch. References: * [OC-98] (CP-39) UCO should implement CI including at least rdf-toolkit runs Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
… observable:OnlineServiceFacet
Merge BugFix-CP-53 (URI typos)
As part of implementing Change Proposal 5, several properties were accidently misspelled with an additional prefix.
This patch fixes the typo pattern outside of the Change Proposal process because it broke SHACL conversion capabilities being used in support of Change Proposal 23.
Python verification script:
```python
import sys
for line in open(sys.argv[1], "r"):
if "rdfs:comment" in line:
continue
if len(line.split(":")) >= 4:
print(line.strip())
```
Acked-by: Alex Nelson <alexander.nelson@nist.gov>
…nition in support of CP-60
…sword and normalized their definitions in support of CP-60
…ObservableObject class from 1 to 0..1 in support of CP-59
…Time in support of CP-58
…entity:CountryOfResidence in support of CP-57
…ology or subontology specification used to characterize a concept." in support of CP-55
… property conveys the recorded size of a file in a file system."@en ; to the owl:restriction for observable:sizeInBytes on the observable:FileFacet class in support of CP-54
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
SHACL implementation (CP-23)
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Removed 'xsd:string' from two properties within observable:MobileDeviceFacet. The two properties: observable:mockLocationsAllowed and observable:phoneActivationTime had two added values from the SHACL conversion. Acked-by: Trevor Bobka <tbobka@mitre.org>
Removed 'xsd:float' from the property restriction of observable:entropy on the observable:WindowsPESection class. Acked-by: Trevor Bobka <tbobka@mitre.org>
Removed 'observable:ObservableObject' from the range on observable:owner and each class that called it as a property restriction. Acked-by: Trevor Bobka <tbobka@mitre.org>
Extended the range of observable:status to be an owl:unionOf xsd:string, observable:TaskStatusVocab, and observable:WhoisStatusVocab. Also, removed the observable:WhoisStatusVocab datatype as a property restriction for observable:status within observable:ProcessFacet. Acked-by: Trevor Bobka <tbobka@mitre.org>
Extended the range of observable:priority to be an owl:unoinOf xsd:integer, xsd:string, and vocabulary:TaskPriorityVocab. Also, removed xsd:string from being a property restriction for observable:priority within observable:WindowsTaskFacet and observable:WindowsThreadFacet. Acked-By: Trevor Bobka <tbobka@mitre.org>
Extended the range of types:entry to include types:DictionaryEntry and types:ControlledDictionaryEntry. Also, removed types:DictionaryEntry from the property restriction for types:entry within the types:ControlledDictionary class. Acked-by: Trevor Bobka <tbobka@mitre.org>
Removed xsd:string according to CP-72
Added the observable:listedCount property that was excluded in the implementation of CP-7. Also, ensured the proper SHACL constraints were added for the its property restriction within observable:TwitterProfileFacet. Acked-by: Trevor Bobka <tbobka@mitre.org>
Implemented CP-73
Implemented CP-74
Implemented CP-75
Implemented CP-76
Implemented CP-78
Fixed syntax with 'unionOf' implementation
References: * [OC-165] (CP-79) Several classes have multiple sh:datatypes and are invalid by SHACL spec Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Add test for sh:datatype count validity
Implemented CP-77
Fixed syntax for 'unionOf' implementation (CP-74)
Late bug fixes for 0.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.