Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CI based on rdf-toolkit and 'make check' design pattern #248

Merged
merged 2 commits into from
May 7, 2021

Conversation

ajnelson-nist
Copy link
Contributor

NOTE - This Pull Request has been filed to illustrate the CI process for discussion at the April UCO OC meeting. It will fail its initial CI run because a domain assertions file was accidentally released in UCO 0.6.0 without normalization.

Tests are implemented base on CASE normalization practices, and by
adapting a recursive-Make normalization pattern from the
CASE-Examples-QC repository.

`lib/Makfile` was copied directly from CASE 0.3.0.

`src/review.mk` was adapted from the CASE-Examples-QC repository's
`normalize` recipe.  It now uses GNU Make functionality to identify
ontology file directories and sometimes-present Turtle files (esp.
`*-da.ttl`), instead of hard-coding file references that might be
forgotten to be updated over time.

References:
* [CASE ONT-251] (CP-16) Establish unit tests, possibly Continuous
  Integration, for ontology repository
* [CASE-Examples-QC] https://github.com/ajnelson-nist/CASE-Examples-QC
* [OC-98] (CP-39) UCO should implement CI including at least rdf-toolkit
  runs

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Unit testing revealed this file had unsorted content.

No semantic changes are made in this patch.

References:
* [OC-98] (CP-39) UCO should implement CI including at least rdf-toolkit
  runs

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@sbarnum sbarnum merged commit 0b6d8bb into develop May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants