Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning from matplotlib #764

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Fix warning from matplotlib #764

merged 2 commits into from
Jul 5, 2023

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Jul 5, 2023

Description

The matplotlib warning should be gone now.

Closes #742

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

@zhuchcn zhuchcn requested a review from lydiayliu July 5, 2023 18:02
Copy link
Collaborator

@lydiayliu lydiayliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to try this! But will the warning persist for users that don't use the docker?

@zhuchcn
Copy link
Member Author

zhuchcn commented Jul 5, 2023

You shouldn't see this other than docker, because should have the write permission to the default matplotlib config directory.

@zhuchcn zhuchcn merged commit 3d78cf1 into main Jul 5, 2023
@zhuchcn zhuchcn deleted the czhu-fix-docker branch July 5, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning message from matplotlib
2 participants