-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/index scoped tiered access #802
Conversation
…feat/index-scoped-tiered-access
…feat/index-scoped-tiered-access
…feat/index-scoped-tiered-access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think whatever you put into Dependency updates
should goes into Deployment changes
// contain a tierAccessLevel. | ||
let indexScopedTierAccessMode = true; | ||
explorerConfig.forEach((item) => { | ||
if (!item.guppyConfig || !item.guppyConfig.tierAccessLevel) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: probably should just freak out if there is no guppyConfig
, that block is required for each explorer tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the localconf.js file does not throw any errors or intentionally abort builds. i'm gonna keep with that convention
and also might be good to mention index-scoped access level only available since guppy version XXX |
for sure, i'll add that once Marcelo has QA'd my Guppy PR and it's merged and versioned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
personally lgtm, let's merge after uc-cdis/guppy#104
…feat/index-scoped-tiered-access
…feat/index-scoped-tiered-access
Jira Ticket: https://ctds-planx.atlassian.net/browse/HP-31
New Features
Deployment Changes