Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(prod-test): Also scan s3 buckets in access check script #1635

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Fix(prod-test): Also scan s3 buckets in access check script #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
648a170
fix(prod-testing): Also scan s3 buckets in access check automation
themarcelor Jun 16, 2021
2aa1fcc
bump up gen3-qa-controller img version
themarcelor Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gen3/bin/gen3qa-run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ case "$test" in
g3kubectl logs $(gen3 pod gen3qa-check-bucket-access) -c gen3qa-check-bucket-access -f
echo "press ctrl+C to quit..."
# TODO: This hack is necessary due to the nature of the Selenium sidecar
# CodeceptJS has a hard dependency on a running Selenium so that is the only way to run suites/google/checkAllProjectsGoogleBucketAccessTest.js
# CodeceptJS has a hard dependency on a running Selenium so that is the only way to run suites/prod/checkAllProjectsBucketAccessTest.js
# We should create a selenium-standlone wrapper docker img with a proper kill switch
trap terminate_pod SIGINT
sleep infinity
Expand Down
6 changes: 3 additions & 3 deletions kube/services/jobs/gen3qa-check-bucket-access-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
spec:
containers:
- name: gen3qa-check-bucket-access
GEN3_GEN3_QA_CONTROLLER_IMAGE|-image: quay.io/cdis/gen3-qa-controller:0.3-|
GEN3_GEN3_QA_CONTROLLER_IMAGE|-image: quay.io/cdis/gen3-qa-controller:0.4-|
workingDir: /var/sdet_home
imagePullPolicy: Always
env:
Expand All @@ -25,8 +25,8 @@ spec:
- "-c"
- |
set +x
echo "running checkAllProjectsGoogleBucketAccessTest.js..."
INDEXD_FILTER=$INDEXD_QUERY_FILTER GEN3_SKIP_PROJ_SETUP=true npm test -- suites/google/checkAllProjectsGoogleBucketAccessTest.js
echo "running checkAllProjectsBucketAccessTest.js..."
INDEXD_FILTER=$INDEXD_QUERY_FILTER GEN3_SKIP_PROJ_SETUP=true npm test -- suites/prod/checkAllProjectsBucketAccessTest.js
RC=$?
if [[ $RC != 0 ]]; then
echo "ERROR: non zero exit code: $?"
Expand Down