Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(prod-test): Also scan s3 buckets in access check script #1635

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Fix(prod-test): Also scan s3 buckets in access check script #1635

merged 2 commits into from
Jun 17, 2021

Conversation

themarcelor
Copy link
Contributor

We should perform the bucket-access-check for both gs and s3 protocols. Not just for Google Buckets.

  • New gen3-qa-controller img version/

haraprasadj
haraprasadj approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@haraprasadj haraprasadj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

atharvar28
atharvar28 reviewed Jun 17, 2021
View reviewed changes
Copy link
Contributor

@atharvar28 atharvar28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@atharvar28 atharvar28 self-requested a review June 17, 2021 14:49
@themarcelor themarcelor merged commit 804ce31 into master Jun 17, 2021
@themarcelor themarcelor deleted the fix/new_gen3qa_script branch June 17, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haraprasadj haraprasadj haraprasadj approved these changes

@atharvar28 atharvar28 atharvar28 approved these changes

@Avantol13 Avantol13 Awaiting requested review from Avantol13

@emalinowski emalinowski Awaiting requested review from emalinowski

@jingh8 jingh8 Awaiting requested review from jingh8

Assignees
No one assigned
Labels
skip-awshelper-build-wait skip-gen3-helper-tests test-portal-homepageTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themarcelor @haraprasadj @atharvar28