-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev ktrx rebase #453
Merged
Merged
Dev ktrx rebase #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update plot.py * fix bug and refine prediction plot * Update quick_start.ipynb * Update plot.py
* resolve conflicts * resolve conflicts * rebase commit * Prediction Plot Bug Fix and Enhance (#428) * Update plot.py * fix bug and refine prediction plot * Update quick_start.ipynb * Update plot.py * rebase commit
* rebase from dev * temp * Update build_your_own_model.ipynb * refine tutorials and ktrlite knots plotting * Update ktrlite.ipynb * palette and docstring * more verbiage Co-authored-by: Zhishi Wang <zhishiw@uber.com>
* arviz * get_posterior_samples * arviz plotting * arviz demo * rename * fix kwargs * refine plotting
* more robust way to extract signatures of orbit models * unit test for grid search * replace regressor beta prior tuning with other params
* ktr lite house keeping - revert level knots plot - refine tutorial - refine some plotting code * more house keeping - [x] enhance unit test - [x] relable pool - [x] initializer of ktrlite * notebook update * Update test_ktrlite.py * Update test_ktrlite.py * add comment for stan_extract cleaning Co-authored-by: Zhishi Wang <zhishiw@uber.com>
* refine estimator to include training metrics for NUTS and SVI * Update pyro_basic.ipynb * add comment for stan_extract cleaning Co-authored-by: Zhishi Wang <zhishiw@uber.com> Co-authored-by: Zhishi Wang <wangzhishi@users.noreply.github.com> Co-authored-by: Zhishi Wang <zhishiw@uber.com>
wangzhishi
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve rebase conflicts; get updated functions from dev