Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev ktrx rebase #453

Merged
merged 14 commits into from
Jun 3, 2021
Merged

Dev ktrx rebase #453

merged 14 commits into from
Jun 3, 2021

Conversation

edwinnglabs
Copy link
Collaborator

Description

Resolve rebase conflicts; get updated functions from dev

Edwin Ng and others added 13 commits June 2, 2021 21:08
* Update plot.py

* fix bug and refine prediction plot

* Update quick_start.ipynb

* Update plot.py
* resolve conflicts

* resolve conflicts

* rebase commit

* Prediction Plot Bug Fix and Enhance (#428)

* Update plot.py

* fix bug and refine prediction plot

* Update quick_start.ipynb

* Update plot.py

* rebase commit
* rebase from dev

* temp

* Update build_your_own_model.ipynb

* refine tutorials and ktrlite knots plotting

* Update ktrlite.ipynb

* palette and docstring

* more verbiage

Co-authored-by: Zhishi Wang <zhishiw@uber.com>
* arviz

* get_posterior_samples

* arviz plotting

* arviz demo

* rename

* fix kwargs

* refine plotting
* more robust way to extract signatures of orbit models

* unit test for grid search

* replace regressor beta prior tuning with other params
* ktr lite house keeping

- revert level knots plot
- refine tutorial
- refine some plotting code

* more house keeping

- [x] enhance unit test
- [x] relable pool
- [x] initializer of ktrlite

* notebook update

* Update test_ktrlite.py

* Update test_ktrlite.py

* add comment for stan_extract cleaning

Co-authored-by: Zhishi Wang <zhishiw@uber.com>
* refine estimator to include training metrics for NUTS and SVI

* Update pyro_basic.ipynb

* add comment for stan_extract cleaning

Co-authored-by: Zhishi Wang <zhishiw@uber.com>

Co-authored-by: Zhishi Wang <wangzhishi@users.noreply.github.com>
Co-authored-by: Zhishi Wang <zhishiw@uber.com>
@edwinnglabs edwinnglabs requested a review from wangzhishi June 3, 2021 06:11
@edwinnglabs edwinnglabs added the review needed need someone to review label Jun 3, 2021
Copy link
Contributor

@wangzhishi wangzhishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwinnglabs edwinnglabs merged commit c791d50 into dev-ktrx Jun 3, 2021
@edwinnglabs edwinnglabs deleted the dev-ktrx-rebase branch June 3, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review needed need someone to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants