ktr lite house keeping #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- revert level knots plot - refine tutorial - refine some plotting code
added 4 commits
May 23, 2021 17:16
- [x] enhance unit test - [x] relable pool - [x] initializer of ktrlite
wangzhishi
reviewed
May 28, 2021
| x for x in self._level_knot_dates if | ||
| (x <= df[self.date_col].max()) and (x >= df[self.date_col].min()) | ||
| x for x in self._level_knot_dates if | ||
| (x <= df[self.date_col].values[-1]) and (x >= df[self.date_col].values[0]) |
There was a problem hiding this comment.
this is assuming that df is sorted by date_col, though this should be a requirement for our model.
There was a problem hiding this comment.
just curious if there is any special consideration in this change?
There was a problem hiding this comment.
i have some impression that is what we check by default in the see _validate_training_df under base template.
edwinnglabs
pushed a commit
that referenced
this pull request
May 30, 2021
* ktr lite house keeping - revert level knots plot - refine tutorial - refine some plotting code * more house keeping - [x] enhance unit test - [x] relable pool - [x] initializer of ktrlite * notebook update * Update test_ktrlite.py * Update test_ktrlite.py * add comment for stan_extract cleaning Co-authored-by: Zhishi Wang <zhishiw@uber.com>
edwinnglabs
pushed a commit
that referenced
this pull request
Jun 3, 2021
* ktr lite house keeping - revert level knots plot - refine tutorial - refine some plotting code * more house keeping - [x] enhance unit test - [x] relable pool - [x] initializer of ktrlite * notebook update * Update test_ktrlite.py * Update test_ktrlite.py * add comment for stan_extract cleaning Co-authored-by: Zhishi Wang <zhishiw@uber.com>
edwinnglabs
pushed a commit
that referenced
this pull request
Jun 3, 2021
* Prediction Plot Bug Fix and Enhance (#428) * Update plot.py * fix bug and refine prediction plot * Update quick_start.ipynb * Update plot.py * Predicion refactor (#430) * resolve conflicts * resolve conflicts * rebase commit * Prediction Plot Bug Fix and Enhance (#428) * Update plot.py * fix bug and refine prediction plot * Update quick_start.ipynb * Update plot.py * rebase commit * Refine KTRLite plotting and tutorial (#431) * rebase from dev * temp * Update build_your_own_model.ipynb * refine tutorials and ktrlite knots plotting * Update ktrlite.ipynb * palette and docstring * more verbiage Co-authored-by: Zhishi Wang <zhishiw@uber.com> * Update build_your_own_model.ipynb * Update build_your_own_model.ipynb * Feat arviz (#433) * arviz * get_posterior_samples * arviz plotting * arviz demo * rename * fix kwargs * refine plotting * more robust way to extract signatures of orbit models (#438) * more robust way to extract signatures of orbit models * unit test for grid search * replace regressor beta prior tuning with other params * ktr lite house keeping (#440) * ktr lite house keeping - revert level knots plot - refine tutorial - refine some plotting code * more house keeping - [x] enhance unit test - [x] relable pool - [x] initializer of ktrlite * notebook update * Update test_ktrlite.py * Update test_ktrlite.py * add comment for stan_extract cleaning Co-authored-by: Zhishi Wang <zhishiw@uber.com> * ELBO Loss Extraction (#443) * refine estimator to include training metrics for NUTS and SVI * Update pyro_basic.ipynb * add comment for stan_extract cleaning Co-authored-by: Zhishi Wang <zhishiw@uber.com> Co-authored-by: Zhishi Wang <wangzhishi@users.noreply.github.com> Co-authored-by: Zhishi Wang <zhishiw@uber.com> * use newly written arviz wrappers for diagnostic tutorial (#446) * resolve conflicts * rebase * rebase with dev * Update template.py Co-authored-by: Zhishi Wang <zhishiw@uber.com> Co-authored-by: Zhishi Wang <wangzhishi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems the older version of plot is more informative. I'm proposing to revert it with some better implementation.
Fixes #441