Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Theme Inversion #590

Merged
merged 4 commits into from
Jul 6, 2023
Merged

New Theme Inversion #590

merged 4 commits into from
Jul 6, 2023

Conversation

j-mie6
Copy link
Collaborator

@j-mie6 j-mie6 commented Jun 30, 2023

Some people were unapply with the sheer in-your-face redness of the new theme introduced in #573, so this just inverts the primary and secondary colours, creating a bit better of a balance. With this, the lighter red is brought back, which is a bit more soft (but had bad contrast at the small sizes on the nav-bar), and the landing page changes from #586 have been incorporated.

However, the landing page in Laika is not particularly well set-up for light backgrounds, so while we wait for that to be properly decoupled (text colour-wise), there is an interim darker landing page (note the button colour on that screenshot has since been altered):

image

image

Obviously, there is no default landing page for SBT typelevel currently, but this means the theme is currently a bit more future proofed. Eventually, the landing page will be lightened and all will be well with the world.

@mergify mergify bot added the site label Jun 30, 2023
@j-mie6 j-mie6 force-pushed the design/invert-theme branch from 93c72c4 to a318800 Compare July 5, 2023 16:35
@j-mie6 j-mie6 marked this pull request as draft July 5, 2023 16:35
@j-mie6
Copy link
Collaborator Author

j-mie6 commented Jul 5, 2023

With the merging of #594 the interim dark landing colours have been removed in favour of:

image

@j-mie6 j-mie6 marked this pull request as ready for review July 5, 2023 16:52
@jenshalm
Copy link
Contributor

jenshalm commented Jul 5, 2023

A few fairly minor things I noticed for the normal content pages:

  • The primaryMedium used for borders and lines is very light and barely visible. If you want to keep this tint for the landing page gradient, you could create one that is a tad darker for the normal pages.

  • Literals in syntax highlighting are very dark, I find them hard to read. Even if it's temporary I think it would be good to make it a bit brighter.

  • The background for code blocks is similar, but different to primary. It might look more harmonic if you use primary as syntax-bg, too

And I think it would be nice to remove unused/commented colors.

@j-mie6 j-mie6 marked this pull request as draft July 5, 2023 17:10
…ted more towards the green-end of cyan to distinguish, medium color darkened
@j-mie6
Copy link
Collaborator Author

j-mie6 commented Jul 5, 2023

Addressed some of those (kept code background the same, as it is the colour for the TL logo's font and the main text colour:

image

(Also removed some unneeded colours, but kept redTl just in case)

@j-mie6 j-mie6 marked this pull request as ready for review July 5, 2023 17:25
@jenshalm
Copy link
Contributor

jenshalm commented Jul 5, 2023

Looks good to me now.

@j-mie6 j-mie6 merged commit 2c7e552 into typelevel:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants