-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New light theme for sbt-typelevel-site
!
#573
Conversation
I like it, but I'm concerned about accessibility with the low contrast on the left. It can be checked against WCAG guidelines. Incidentally, the current version passes for large text and fails for small text, so this is a great chance to improve the status quo, too! |
I did check the syntax colouring for any concerns under firefox accessibility tools, and it was fine, didn't check side bar (I do have |
Yup, even |
@rossabaker hopefully that's a bit better (contrast should now be the same as it is for the main typelevel.org site) Improving it further would also mean darkening the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe I'd rather a code light theme to go with the rest of the light theme, but that's not really the point of this PR anyway. This is a good idea and it looks like an improvement to me.
ff4s has a nice light theme we might take inspiration from. |
I can definitely make a code light theme, then can use this one for the (future) dark theme; light theme code highlighting is a bit trickier imo (weirdly!), So that can always come in a later PR (this doesn't need to be final, after all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I'm very excited about this. I can't thank you enough! 🥰
@danicheg @satorg @ChristopherDavenport polite pings in case you have any opinions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this 👍🏻 But it'd be good to check that this colour palette is also fine for people with visual impairments https://www.whocanuse.com/.
I did run it through the Firefox impairment simulators at least and things seemed fine. Except for red-less colour blindness, that was fine but just... Bleak. That's to be expected, of course. |
That said, if any issues come up I'll be happy to find a fix for them :) (just @ me) |
@all-contributors add @j-mie6 for design |
I've put up a pull request to add @j-mie6! 🎉 |
Changed the default Helium theme over to one more clearly embodying the typelevel colours as found on the main website. Reworked the colours and syntax highlighting. Colours taken from typelevel are clearly labelled as such.
Here is an example: