Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New light theme for sbt-typelevel-site! #573

Merged
merged 6 commits into from
Jun 29, 2023

Conversation

j-mie6
Copy link
Collaborator

@j-mie6 j-mie6 commented Jun 26, 2023

Changed the default Helium theme over to one more clearly embodying the typelevel colours as found on the main website. Reworked the colours and syntax highlighting. Colours taken from typelevel are clearly labelled as such.

Here is an example:

image

@rossabaker
Copy link
Member

I like it, but I'm concerned about accessibility with the low contrast on the left. It can be checked against WCAG guidelines. Incidentally, the current version passes for large text and fails for small text, so this is a great chance to improve the status quo, too!

@j-mie6
Copy link
Collaborator Author

j-mie6 commented Jun 26, 2023

I did check the syntax colouring for any concerns under firefox accessibility tools, and it was fine, didn't check side bar (I do have redTl up my sleeve vs the brightRedTl colour, so that might help if necessary. (Thanks for pointing that out!)

@j-mie6
Copy link
Collaborator Author

j-mie6 commented Jun 26, 2023

Yup, even redTl, (which actually looks a tad nicer imo) is a bit shy of the contrast requirements, I'll see if I can brighten the light pink a little more to fix it and will post an update screenshot :)

@j-mie6
Copy link
Collaborator Author

j-mie6 commented Jun 26, 2023

image

@rossabaker hopefully that's a bit better (contrast should now be the same as it is for the main typelevel.org site)

Improving it further would also mean darkening the redTl, which would also carry through to the main typelevel.org: I'll happily just mirror any colours that appear over there 🙂

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe I'd rather a code light theme to go with the rest of the light theme, but that's not really the point of this PR anyway. This is a good idea and it looks like an improvement to me.

@armanbilge
Copy link
Member

armanbilge commented Jun 27, 2023

ff4s has a nice light theme we might take inspiration from.
https://buntec.github.io/ff4s/examples/counter.html

@j-mie6
Copy link
Collaborator Author

j-mie6 commented Jun 27, 2023

I can definitely make a code light theme, then can use this one for the (future) dark theme; light theme code highlighting is a bit trickier imo (weirdly!), So that can always come in a later PR (this doesn't need to be final, after all!

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'm very excited about this. I can't thank you enough! 🥰

@danicheg @satorg @ChristopherDavenport polite pings in case you have any opinions :)

Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this 👍🏻 But it'd be good to check that this colour palette is also fine for people with visual impairments https://www.whocanuse.com/.

@j-mie6
Copy link
Collaborator Author

j-mie6 commented Jun 28, 2023

I like this 👍🏻 But it'd be good to check that this colour palette is also fine for people with visual impairments https://www.whocanuse.com/.

I did run it through the Firefox impairment simulators at least and things seemed fine. Except for red-less colour blindness, that was fine but just... Bleak. That's to be expected, of course.

@j-mie6
Copy link
Collaborator Author

j-mie6 commented Jun 28, 2023

That said, if any issues come up I'll be happy to find a fix for them :) (just @ me)

@armanbilge armanbilge merged commit ec7a2c9 into typelevel:main Jun 29, 2023
@armanbilge
Copy link
Member

@all-contributors add @j-mie6 for design

@allcontributors
Copy link
Contributor

@armanbilge

I've put up a pull request to add @j-mie6! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants